diff for duplicates of <1473392840.30217.170.camel@buserror.net> diff --git a/a/1.txt b/N1/1.txt index 6429a87..c10dd2c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -169,3 +169,8 @@ you use devm). Don't ifdef prototypes (unless you're going to provide a stub alternative). -Scott + +_______________________________________________ +iommu mailing list +iommu@lists.linux-foundation.org +https://lists.linuxfoundation.org/mailman/listinfo/iommu diff --git a/a/content_digest b/N1/content_digest index 1220f64..1b46cd7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,32 +1,32 @@ "ref\01473150503-9550-1-git-send-email-yangbo.lu@nxp.com\0" "ref\01473150503-9550-6-git-send-email-yangbo.lu@nxp.com\0" - "From\0Scott Wood <oss@buserror.net>\0" + "ref\01473150503-9550-6-git-send-email-yangbo.lu-3arQi8VN3Tc@public.gmane.org\0" + "From\0Scott Wood <oss-fOR+EgIDQEHk1uMJSBkQmQ@public.gmane.org>\0" "Subject\0Re: [v11, 5/8] soc: fsl: add GUTS driver for QorIQ platforms\0" "Date\0Thu, 08 Sep 2016 22:47:20 -0500\0" - "To\0Yangbo Lu <yangbo.lu@nxp.com>" - linux-mmc@vger.kernel.org - ulf.hansson@linaro.org - " Arnd Bergmann <arnd@arndb.de>\0" - "Cc\0linuxppc-dev@lists.ozlabs.org" - devicetree@vger.kernel.org - linux-arm-kernel@lists.infradead.org - linux-kernel@vger.kernel.org - linux-clk@vger.kernel.org - linux-i2c@vger.kernel.org - iommu@lists.linux-foundation.org - netdev@vger.kernel.org - Mark Rutland <mark.rutland@arm.com> - Rob Herring <robh+dt@kernel.org> - Russell King <linux@arm.linux.org.uk> - Jochen Friedrich <jochen@scram.de> - Joerg Roedel <joro@8bytes.org> - Claudiu Manoil <claudiu.manoil@freescale.com> - Bhupesh Sharma <bhupesh.sharma@freescale.com> - Qiang Zhao <qiang.zhao@nxp.com> - Kumar Gala <galak@codeaurora.org> - Santosh Shilimkar <ssantosh@kernel.org> - leoyang.li@nxp.com - " xiaobo.xie@nxp.com\0" + "To\0Yangbo Lu <yangbo.lu-3arQi8VN3Tc@public.gmane.org>" + linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org + " Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>\0" + "Cc\0Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>" + devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> + Bhupesh Sharma <bhupesh.sharma-KZfg59tc24xl57MIdRCFDg@public.gmane.org> + netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + Santosh Shilimkar <ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> + linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + Jochen Friedrich <jochen-NIgtFMG+Po8@public.gmane.org> + xiaobo.xie-3arQi8VN3Tc@public.gmane.org + iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org + Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> + linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + Claudiu Manoil <claudiu.manoil-KZfg59tc24xl57MIdRCFDg@public.gmane.org> + Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> + leoyang.li-3arQi8VN3Tc@public.gmane.org + linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org + linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org + " Qiang Zhao <qiang.zhao-3arQi8VN3Tc@public.gmane.org>\0" "\00:1\0" "b\0" "On Tue, 2016-09-06 at 16:28 +0800, Yangbo Lu wrote:\n" @@ -199,6 +199,11 @@ "\n" "Don't ifdef prototypes (unless you're going to provide a stub alternative).\n" "\n" - -Scott + "-Scott\n" + "\n" + "_______________________________________________\n" + "iommu mailing list\n" + "iommu@lists.linux-foundation.org\n" + https://lists.linuxfoundation.org/mailman/listinfo/iommu -8864d3cbaa4225ef99fb1cb3d851ba117ce77910d187ee09ca9f890741f05b13 +5001267e0599c9158b6aa3ae97939beb639a949a8753a58b013a93bfe6d15de6
diff --git a/a/1.txt b/N2/1.txt index 6429a87..4a4cc62 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -11,7 +11,7 @@ On Tue, 2016-09-06 at 16:28 +0800, Yangbo Lu wrote: > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> > Signed-off-by: Scott Wood <oss@buserror.net> -Don't put my signoff on patches that I didn't put it on myself. Definitely +Don't put my signoff on patches that I didn't put it on myself. ?Definitely don't put mine *after* yours on patches that were last modified by you. If you want to mention that the soc_id encoding was my suggestion, then do so @@ -21,15 +21,15 @@ explicitly. > +static const struct soc_device_attribute qoriq_soc[] = { > +#ifdef CONFIG_PPC > + /* -> + * Power Architecture-based SoCs T Series -> + */ +> + ?* Power Architecture-based SoCs T Series +> + ?*/ > + > + /* SoC: T1024/T1014/T1023/T1013 Rev: 1.0 */ > + { .soc_id = "svr:0x85400010,name:T1024,die:T1024", -> + .revision = "1.0", +> + ??.revision = "1.0", > + }, > + { .soc_id = "svr:0x85480010,name:T1024E,die:T1024", -> + .revision = "1.0", +> + ??.revision = "1.0", > + }, Revision could be computed from the low 8 bits of SVR (just as you do for unknown SVRs). @@ -42,12 +42,12 @@ We could move the die name into .family: } I see you dropped svre (and the trailing comma), though I guess the vast -majority of potential users will be looking at .family. In which case do we -even need name? If we just make the soc_id be "svr:0xnnnnnnnn" then we could -shrink the table to an svr+mask that identifies each die. I'd still want to +majority of potential users will be looking at .family. ?In which case do we +even need name? ?If we just make the soc_id be "svr:0xnnnnnnnn" then we could +shrink the table to an svr+mask that identifies each die. ?I'd still want to keep the "svr:" even if we're giving up on the general tagging system, to make it clear what the number refers to, and to provide some defense against users -who match only against soc_id rather than soc_id+family. Or we could go +who match only against soc_id rather than soc_id+family. ?Or we could go further and format soc_id as "QorIQ SVR 0xnnnnnnnn" so that soc_id-only matches are fully acceptable rather than just less dangerous. @@ -94,12 +94,12 @@ Couldn't this be statically allocated? > + fsl_soc = fsl_soc_device_match(svr, qoriq_soc); > + if (fsl_soc) { > + soc_dev_attr->soc_id = kasprintf(GFP_KERNEL, "%s", -> + fsl_soc->soc_id); +> + ?fsl_soc->soc_id); You can use kstrdup() if you're just copying the string as is. > + soc_dev_attr->revision = kasprintf(GFP_KERNEL, "%s", -> + fsl_soc->revision); +> + ???fsl_soc->revision); > + } else { > + soc_dev_attr->soc_id = kasprintf(GFP_KERNEL, "0x%08x", > svr); @@ -161,7 +161,7 @@ devm Don't free the memory before you unregister the device that uses it (moot if you use devm). -> +> ? > +#ifdef CONFIG_FSL_GUTS > +unsigned int fsl_guts_get_svr(void); > +#endif diff --git a/a/content_digest b/N2/content_digest index 1220f64..5cb8a60 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,32 +1,9 @@ "ref\01473150503-9550-1-git-send-email-yangbo.lu@nxp.com\0" "ref\01473150503-9550-6-git-send-email-yangbo.lu@nxp.com\0" - "From\0Scott Wood <oss@buserror.net>\0" - "Subject\0Re: [v11, 5/8] soc: fsl: add GUTS driver for QorIQ platforms\0" + "From\0oss@buserror.net (Scott Wood)\0" + "Subject\0[v11, 5/8] soc: fsl: add GUTS driver for QorIQ platforms\0" "Date\0Thu, 08 Sep 2016 22:47:20 -0500\0" - "To\0Yangbo Lu <yangbo.lu@nxp.com>" - linux-mmc@vger.kernel.org - ulf.hansson@linaro.org - " Arnd Bergmann <arnd@arndb.de>\0" - "Cc\0linuxppc-dev@lists.ozlabs.org" - devicetree@vger.kernel.org - linux-arm-kernel@lists.infradead.org - linux-kernel@vger.kernel.org - linux-clk@vger.kernel.org - linux-i2c@vger.kernel.org - iommu@lists.linux-foundation.org - netdev@vger.kernel.org - Mark Rutland <mark.rutland@arm.com> - Rob Herring <robh+dt@kernel.org> - Russell King <linux@arm.linux.org.uk> - Jochen Friedrich <jochen@scram.de> - Joerg Roedel <joro@8bytes.org> - Claudiu Manoil <claudiu.manoil@freescale.com> - Bhupesh Sharma <bhupesh.sharma@freescale.com> - Qiang Zhao <qiang.zhao@nxp.com> - Kumar Gala <galak@codeaurora.org> - Santosh Shilimkar <ssantosh@kernel.org> - leoyang.li@nxp.com - " xiaobo.xie@nxp.com\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Tue, 2016-09-06 at 16:28 +0800, Yangbo Lu wrote:\n" @@ -42,7 +19,7 @@ "> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>\n" "> Signed-off-by: Scott Wood <oss@buserror.net>\n" "\n" - "Don't put my signoff on patches that I didn't put it on myself. \302\240Definitely\n" + "Don't put my signoff on patches that I didn't put it on myself. ?Definitely\n" "don't put mine *after* yours on patches that were last modified by you.\n" "\n" "If you want to mention that the soc_id encoding was my suggestion, then do so\n" @@ -52,15 +29,15 @@ "> +static const struct soc_device_attribute qoriq_soc[] = {\n" "> +#ifdef CONFIG_PPC\n" "> +\t/*\n" - "> +\t\302\240* Power Architecture-based SoCs T Series\n" - "> +\t\302\240*/\n" + "> +\t?* Power Architecture-based SoCs T Series\n" + "> +\t?*/\n" "> +\n" "> +\t/* SoC: T1024/T1014/T1023/T1013 Rev: 1.0 */\n" "> +\t{ .soc_id\t= \"svr:0x85400010,name:T1024,die:T1024\",\n" - "> +\t\302\240\302\240.revision\t= \"1.0\",\n" + "> +\t??.revision\t= \"1.0\",\n" "> +\t},\n" "> +\t{ .soc_id\t= \"svr:0x85480010,name:T1024E,die:T1024\",\n" - "> +\t\302\240\302\240.revision\t= \"1.0\",\n" + "> +\t??.revision\t= \"1.0\",\n" "> +\t},\n" "\n" "Revision could be computed from the low 8 bits of SVR (just as you do for unknown SVRs).\n" @@ -73,12 +50,12 @@ "\t}\n" "\n" "I see you dropped svre (and the trailing comma), though I guess the vast\n" - "majority of potential users will be looking at .family. \302\240In which case do we\n" - "even need name? \302\240If we just make the soc_id be \"svr:0xnnnnnnnn\" then we could\n" - "shrink the table to an svr+mask that identifies each die. \302\240I'd still want to\n" + "majority of potential users will be looking at .family. ?In which case do we\n" + "even need name? ?If we just make the soc_id be \"svr:0xnnnnnnnn\" then we could\n" + "shrink the table to an svr+mask that identifies each die. ?I'd still want to\n" "keep the \"svr:\" even if we're giving up on the general tagging system, to make\n" "it clear what the number refers to, and to provide some defense against users\n" - "who match only against soc_id rather than soc_id+family. \302\240Or we could go\n" + "who match only against soc_id rather than soc_id+family. ?Or we could go\n" "further and format soc_id as \"QorIQ SVR 0xnnnnnnnn\" so that soc_id-only\n" "matches are fully acceptable rather than just less dangerous.\n" "\n" @@ -125,12 +102,12 @@ "> +\tfsl_soc = fsl_soc_device_match(svr, qoriq_soc);\n" "> +\tif (fsl_soc) {\n" "> +\t\tsoc_dev_attr->soc_id = kasprintf(GFP_KERNEL, \"%s\",\n" - "> +\t\t\t\t\t\t\302\240fsl_soc->soc_id);\n" + "> +\t\t\t\t\t\t?fsl_soc->soc_id);\n" "\n" "You can use kstrdup() if you're just copying the string as is.\n" "\n" "> +\t\tsoc_dev_attr->revision = kasprintf(GFP_KERNEL, \"%s\",\n" - "> +\t\t\t\t\t\t\302\240\302\240\302\240fsl_soc->revision);\n" + "> +\t\t\t\t\t\t???fsl_soc->revision);\n" "> +\t} else {\n" "> +\t\tsoc_dev_attr->soc_id = kasprintf(GFP_KERNEL, \"0x%08x\",\n" "> svr);\n" @@ -192,7 +169,7 @@ "Don't free the memory before you unregister the device that uses it (moot if\n" "you use devm).\n" "\n" - "> \302\240\n" + "> ?\n" "> +#ifdef CONFIG_FSL_GUTS\n" "> +unsigned int fsl_guts_get_svr(void);\n" "> +#endif\n" @@ -201,4 +178,4 @@ "\n" -Scott -8864d3cbaa4225ef99fb1cb3d851ba117ce77910d187ee09ca9f890741f05b13 +05f8e9a90cc89fe2ee3dad2b462d469e71b7f5128daabeb3b443ff29166b3224
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.