From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Cc: alex.bennee@linaro.org, qemu-devel@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH RFC] target-ppc: tlbie should have global effect
Date: Fri, 09 Sep 2016 15:49:55 +1000 [thread overview]
Message-ID: <1473400195.8689.158.camel@kernel.crashing.org> (raw)
In-Reply-To: <87eg4t7j94.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me>
On Fri, 2016-09-09 at 10:38 +0530, Nikunj A Dadhania wrote:
> One more question, when in gen_check_tlb_flush, don't I need to see
> if other CPU has global flag set ?
No, you leave it completely alone.
You can clear it's local flag as part of the flush (in the MT-TCG case
that can be done by the async handler) because if it had a "dirty" TLB
there is no point in it flushing it twice, but the global flag stays.
If the whole operation was completely synchronous, I suppose you could
clear the other's guy global flag, but it's not so I'd rather not take
chances for now.
Ben.
prev parent reply other threads:[~2016-09-09 5:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 4:23 [Qemu-devel] [PATCH RFC] target-ppc: tlbie should have global effect Nikunj A Dadhania
2016-09-09 4:30 ` Benjamin Herrenschmidt
2016-09-09 4:45 ` Nikunj A Dadhania
2016-09-09 5:00 ` Benjamin Herrenschmidt
2016-09-09 5:03 ` Benjamin Herrenschmidt
2016-09-09 5:08 ` Nikunj A Dadhania
2016-09-09 5:49 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473400195.8689.158.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=alex.bennee@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.