From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biEhf-0002fp-51 for qemu-devel@nongnu.org; Fri, 09 Sep 2016 01:50:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biEhc-0003E0-27 for qemu-devel@nongnu.org; Fri, 09 Sep 2016 01:50:19 -0400 Message-ID: <1473400195.8689.158.camel@kernel.crashing.org> From: Benjamin Herrenschmidt Date: Fri, 09 Sep 2016 15:49:55 +1000 In-Reply-To: <87eg4t7j94.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me> References: <1473395018-15288-1-git-send-email-nikunj@linux.vnet.ibm.com> <1473395444.8689.147.camel@kernel.crashing.org> <87h99p7kax.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me> <1473397204.8689.154.camel@kernel.crashing.org> <87eg4t7j94.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC] target-ppc: tlbie should have global effect List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania , qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Cc: alex.bennee@linaro.org, qemu-devel@nongnu.org, rth@twiddle.net On Fri, 2016-09-09 at 10:38 +0530, Nikunj A Dadhania wrote: > One more question, when in gen_check_tlb_flush, don't I need to see > if other CPU has global flag set ? No, you leave it completely alone. You can clear it's local flag as part of the flush (in the MT-TCG case that can be done by the async handler) because if it had a "dirty" TLB there is no point in it flushing it twice, but the global flag stays. If the whole operation was completely synchronous, I suppose you could clear the other's guy global flag, but it's not so I'd rather not take chances for now. Ben.