From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:60410 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753530AbcIILgm (ORCPT ); Fri, 9 Sep 2016 07:36:42 -0400 Subject: Patch "be2iscsi: Fix bogus WARN_ON length check" has been added to the 3.14-stable tree To: tim.gardner@canonical.com, JBottomley@odin.com, gregkh@linuxfoundation.org, jayamohan.kallickal@avagotech.com, joel@jms.id.au, manoj@linux.vnet.ibm.com, martin.petersen@oracle.com, minh.tran@avagotech.com, sony.john-n@avagotech.com, w@1wt.eu Cc: , From: Date: Fri, 09 Sep 2016 13:36:42 +0200 Message-ID: <14734210025891@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled be2iscsi: Fix bogus WARN_ON length check to the 3.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: be2iscsi-fix-bogus-warn_on-length-check.patch and it can be found in the queue-3.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From dd29dae00d39186890a5eaa2fe4ad8768bfd41a9 Mon Sep 17 00:00:00 2001 From: Tim Gardner Date: Fri, 30 Oct 2015 12:22:58 -0600 Subject: be2iscsi: Fix bogus WARN_ON length check From: Tim Gardner commit dd29dae00d39186890a5eaa2fe4ad8768bfd41a9 upstream. drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous': drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] WARN_ON(!length > 0); gcc version 5.2.1 Signed-off-by: Tim Gardner Cc: Jayamohan Kallickal Cc: Minh Tran Cc: John Soni Jose Cc: "James E.J. Bottomley" Reported-by: Joel Stanley Reviewed-by: Manoj Kumar Signed-off-by: Martin K. Petersen Cc: Willy Tarreau Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/be2iscsi/be_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -3172,7 +3172,7 @@ be_sgl_create_contiguous(void *virtual_a { WARN_ON(!virtual_address); WARN_ON(!physical_address); - WARN_ON(!length > 0); + WARN_ON(!length); WARN_ON(!sgl); sgl->va = virtual_address; Patches currently in stable-queue which might be from tim.gardner@canonical.com are queue-3.14/be2iscsi-fix-bogus-warn_on-length-check.patch