From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>
Subject: Re: Regulator probe
Date: Fri, 09 Sep 2016 19:10:39 +0300 [thread overview]
Message-ID: <1473437439.11323.188.camel@linux.intel.com> (raw)
In-Reply-To: <20160909152952.GS27946@sirena.org.uk>
On Fri, 2016-09-09 at 16:29 +0100, Mark Brown wrote:
> > Fixed regulator probe is deferred:
>
> >
> > reg-fixed-voltage reg-fixed-voltage.0.auto: Failed to register
> > regulator: -517
>
> So the regulator probe *does* get deferred as expected...
>
> >
> > But:
> > sdhci-pci 0000:00:01.3: No vmmc regulator found
>
> >
> > Code in sdhci driver is:
> > ret = mmc_regulator_get_supply(mmc);
> > if (ret == -EPROBE_DEFER)
> > return ret;
> >
> > mmc_regulator_get_supply():
> > ...
> > mmc->supply.vmmc = devm_regulator_get_optional(dev, "vmmc");
> > mmc->supply.vqmmc = devm_regulator_get_optional(dev,
> > "vqmmc");
>
> ...and then we correctly report that the optional supply that isn't
> mapped (as far as I remember) isn't there.
But it *will be* soon there.
Hmm... And the proper fix for this case is... (let's assume there will
not be device tree solution in nearest future)?
If I remove has_full_constraints() call I will get EPROBE_DEFER on all
optional regulators IIRC.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-09-09 16:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 14:53 Regulator probe Andy Shevchenko
2016-09-01 15:38 ` Mark Brown
2016-09-01 16:15 ` Andy Shevchenko
2016-09-01 17:02 ` Mark Brown
2016-09-05 16:01 ` Andy Shevchenko
2016-09-06 10:24 ` Mark Brown
2016-09-07 14:24 ` Andy Shevchenko
2016-09-09 12:17 ` Mark Brown
2016-09-09 12:55 ` Andy Shevchenko
2016-09-09 15:29 ` Mark Brown
2016-09-09 16:10 ` Andy Shevchenko [this message]
2016-09-09 16:38 ` Mark Brown
2016-09-09 17:04 ` Andy Shevchenko
2016-09-09 17:18 ` Mark Brown
2016-09-10 11:03 ` Andy Shevchenko
2016-09-12 15:27 ` Mark Brown
2016-09-12 16:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473437439.11323.188.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.