From: Patrick Ohly <patrick.ohly@intel.com>
To: yocto@yoctoproject.org
Cc: joshua.g.lock@intel.com
Subject: [meta-swupd][PATCH] swupdimage.bbclass: ensure that do_rootfs gets executed
Date: Mon, 12 Sep 2016 09:09:26 +0200 [thread overview]
Message-ID: <1473664166-2472-1-git-send-email-patrick.ohly@intel.com> (raw)
OE-core commit 6d969bacc718e changed do_rootfs so that it creates
IMGDEPLOYDIR. That change broke the creation of additional swupd
images, because setting do_rootfs to empty caused the entire task to
be skipped, including the evaluation of the 'cleandirs' task
attribute.
It remains to be seen whether that's really the desired behavior (see
https://bugzilla.yoctoproject.org/show_bug.cgi?id=10256), but as it is
what it is right now, we need to avoid the situation by overwriting
do_rootfs with non-empty code that doesn't do anything. That way, the
directory gets created.
Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
---
classes/swupdimage.bbclass | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/classes/swupdimage.bbclass b/classes/swupdimage.bbclass
index 20bd4c8..56aa60a 100644
--- a/classes/swupdimage.bbclass
+++ b/classes/swupdimage.bbclass
@@ -48,7 +48,11 @@ python swupdimage_virtclass_handler () {
e.data.setVar("IMAGE_BUNDLE_NAME", imageext)
# We override the default methods such that they only copy from the mega rootfs.
e.data.setVar("do_image", " import swupd.rootfs\n swupd.rootfs.create_rootfs(d)\n")
- e.data.setVar("do_rootfs", "")
+ # do_rootfs must not be empty, because empty tasks get skipped
+ # and we don't want that for do_rootfs because its cleandirs
+ # variable triggers the creation of the IMGDEPLOYDIR that we
+ # are going to write into.
+ e.data.setVar("do_rootfs", " pass")
# Depend on complete bundle generation in the base image.
dep = ' %s:do_stage_swupd_inputs' % pn_base
e.data.appendVarFlag('do_image', 'depends', dep)
--
2.1.4
next reply other threads:[~2016-09-12 7:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 7:09 Patrick Ohly [this message]
2016-09-12 7:39 ` [meta-swupd][PATCH] swupdimage.bbclass: ensure that do_rootfs gets executed Patrick Ohly
2016-09-12 11:57 ` Lock, Joshua G
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473664166-2472-1-git-send-email-patrick.ohly@intel.com \
--to=patrick.ohly@intel.com \
--cc=joshua.g.lock@intel.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.