From mboxrd@z Thu Jan 1 00:00:00 1970 From: YT Shen Subject: Re: [PATCH v7 7/9] drm/mediatek: add dsi transfer function Date: Mon, 12 Sep 2016 18:16:21 +0800 Message-ID: <1473675381.12398.27.camel@mtksdaap41> References: <1472815484-43821-1-git-send-email-yt.shen@mediatek.com> <1472815484-43821-8-git-send-email-yt.shen@mediatek.com> <1473215632.11736.21.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1473215632.11736.21.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: CK Hu Cc: Daniel Vetter , Jie Qiu , Mao Huang , yingjoe.chen@mediatek.com, Dan Carpenter , Jitao Shi , Sascha Hauer , linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Matthias Brugger , shaoming chen , linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, Maxime Ripard List-Id: linux-mediatek@lists.infradead.org SGkgQ0ssCgpPbiBXZWQsIDIwMTYtMDktMDcgYXQgMTA6MzMgKzA4MDAsIENLIEh1IHdyb3RlOgo+ IEhpLCBZVDoKPiAKPiBPbiBGcmksIDIwMTYtMDktMDIgYXQgMTk6MjQgKzA4MDAsIFlUIFNoZW4g d3JvdGU6Cj4gPiBGcm9tOiBzaGFvbWluZyBjaGVuIDxzaGFvbWluZy5jaGVuQG1lZGlhdGVrLmNv bT4KPiA+IAo+ID4gYWRkIGRzaSByZWFkL3dyaXRlIGNvbW1hbmRzIGZvciB0cmFuc2ZlciBmdW5j dGlvbgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBzaGFvbWluZyBjaGVuIDxzaGFvbWluZy5jaGVu QG1lZGlhdGVrLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtf ZHNpLmMgfCAxODggKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gIDEg ZmlsZSBjaGFuZ2VkLCAxODggaW5zZXJ0aW9ucygrKQo+ID4gCj4gCj4gW3NuaXAuLi5dCj4gCj4g PiAgCj4gPiArc3RhdGljIHZvaWQgbXRrX2RzaV9pcnFfZGF0YV9jbGVhcihzdHJ1Y3QgbXRrX2Rz aSAqZHNpLCB1MzIgaXJxX2JpdCkKPiA+ICt7Cj4gPiArCWRzaS0+aXJxX2RhdGEgJj0gfmlycV9i aXQ7Cj4gPiArfQo+ID4gKwo+IAo+IFtzbmlwLi4uXQo+IAo+ID4gKwo+ID4gK3N0YXRpYyBzMzIg bXRrX2RzaV93YWl0X2Zvcl9pcnFfZG9uZShzdHJ1Y3QgbXRrX2RzaSAqZHNpLCB1MzIgaXJxX2Zs YWcsCj4gPiArCQkJCSAgICAgdW5zaWduZWQgaW50IHRpbWVvdXQpCj4gPiArewo+ID4gKwlzMzIg cmV0ID0gMDsKPiA+ICsJdW5zaWduZWQgbG9uZyBqaWZmaWVzID0gbXNlY3NfdG9famlmZmllcyh0 aW1lb3V0KTsKPiA+ICsKPiA+ICsJcmV0ID0gd2FpdF9ldmVudF9pbnRlcnJ1cHRpYmxlX3RpbWVv dXQoX2RzaV9pcnFfd2FpdF9xdWV1ZSwKPiA+ICsJCQkJCSAgICAgICBkc2ktPmlycV9kYXRhICYg aXJxX2ZsYWcsCj4gPiArCQkJCQkgICAgICAgamlmZmllcyk7Cj4gPiArCWlmIChyZXQgPT0gMCkg ewo+ID4gKwkJZGV2X2luZm8oZHNpLT5kZXYsICJXYWl0IERTSSBJUlEoMHglMDh4KSBUaW1lb3V0 XG4iLCBpcnFfZmxhZyk7Cj4gPiArCj4gPiArCQltdGtfZHNpX2VuYWJsZShkc2kpOwo+ID4gKwkJ bXRrX2RzaV9yZXNldF9lbmdpbmUoZHNpKTsKPiA+ICsJfQo+ID4gKwo+ID4gKwlyZXR1cm4gcmV0 Owo+ID4gK30KPiAKPiBJIHRoaW5rIG10a19kc2lfaXJxX2RhdGFfY2xlYXIoKSBhbmQgbXRrX2Rz aV93YWl0X2Zvcl9pcnFfZG9uZSgpIHNob3VsZAo+IGJlIG1vdmVkIHRvIHRoZSA2dGggcGF0Y2gg WzFdIG9mIHRoaXMgc2VyaWVzIGJlY2F1c2UgdGhlc2UgdHdvIGZ1bmN0aW9ucwo+IGRlYWwgdGhl IGlycSBjb250cm9sLgpXZSB3aWxsIG1vdmUgbXRrX2RzaV9pcnFfZGF0YV9jbGVhcigpIHRvIHBh dGNoICJkcm0vbWVkaWF0ZWs6IGFkZCBkc2kKaW50ZXJydXB0IGNvbnRyb2wiIGFuZCBwdXQgbXRr X2RzaV93YWl0X2Zvcl9pcnFfZG9uZSgpIGhlcmUsIGJlY2F1c2UgaXQKaXMgdXNlZCBpbiB0aGUg dHJhbnNmZXIgZnVuY3Rpb24uCgpSZWdhcmRzLAp5dC5zaGVuCj4gCj4gCj4gWzFdIGh0dHBzOi8v cGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvOTMxMDgxOS8KPiAKPiAKPiBSZWdhcmRzLAo+IENL Cj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: yt.shen@mediatek.com (YT Shen) Date: Mon, 12 Sep 2016 18:16:21 +0800 Subject: [PATCH v7 7/9] drm/mediatek: add dsi transfer function In-Reply-To: <1473215632.11736.21.camel@mtksdaap41> References: <1472815484-43821-1-git-send-email-yt.shen@mediatek.com> <1472815484-43821-8-git-send-email-yt.shen@mediatek.com> <1473215632.11736.21.camel@mtksdaap41> Message-ID: <1473675381.12398.27.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi CK, On Wed, 2016-09-07 at 10:33 +0800, CK Hu wrote: > Hi, YT: > > On Fri, 2016-09-02 at 19:24 +0800, YT Shen wrote: > > From: shaoming chen > > > > add dsi read/write commands for transfer function > > > > Signed-off-by: shaoming chen > > --- > > drivers/gpu/drm/mediatek/mtk_dsi.c | 188 +++++++++++++++++++++++++++++++++++++ > > 1 file changed, 188 insertions(+) > > > > [snip...] > > > > > +static void mtk_dsi_irq_data_clear(struct mtk_dsi *dsi, u32 irq_bit) > > +{ > > + dsi->irq_data &= ~irq_bit; > > +} > > + > > [snip...] > > > + > > +static s32 mtk_dsi_wait_for_irq_done(struct mtk_dsi *dsi, u32 irq_flag, > > + unsigned int timeout) > > +{ > > + s32 ret = 0; > > + unsigned long jiffies = msecs_to_jiffies(timeout); > > + > > + ret = wait_event_interruptible_timeout(_dsi_irq_wait_queue, > > + dsi->irq_data & irq_flag, > > + jiffies); > > + if (ret == 0) { > > + dev_info(dsi->dev, "Wait DSI IRQ(0x%08x) Timeout\n", irq_flag); > > + > > + mtk_dsi_enable(dsi); > > + mtk_dsi_reset_engine(dsi); > > + } > > + > > + return ret; > > +} > > I think mtk_dsi_irq_data_clear() and mtk_dsi_wait_for_irq_done() should > be moved to the 6th patch [1] of this series because these two functions > deal the irq control. We will move mtk_dsi_irq_data_clear() to patch "drm/mediatek: add dsi interrupt control" and put mtk_dsi_wait_for_irq_done() here, because it is used in the transfer function. Regards, yt.shen > > > [1] https://patchwork.kernel.org/patch/9310819/ > > > Regards, > CK > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757601AbcILKQ2 (ORCPT ); Mon, 12 Sep 2016 06:16:28 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:54729 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1757282AbcILKQ0 (ORCPT ); Mon, 12 Sep 2016 06:16:26 -0400 Message-ID: <1473675381.12398.27.camel@mtksdaap41> Subject: Re: [PATCH v7 7/9] drm/mediatek: add dsi transfer function From: YT Shen To: CK Hu CC: , Philipp Zabel , David Airlie , Matthias Brugger , Daniel Kurtz , Mao Huang , Bibby Hsieh , "Daniel Vetter" , Thierry Reding , Jie Qiu , Maxime Ripard , Chris Wilson , shaoming chen , Jitao Shi , Boris Brezillon , Dan Carpenter , , , , , Sascha Hauer , , Date: Mon, 12 Sep 2016 18:16:21 +0800 In-Reply-To: <1473215632.11736.21.camel@mtksdaap41> References: <1472815484-43821-1-git-send-email-yt.shen@mediatek.com> <1472815484-43821-8-git-send-email-yt.shen@mediatek.com> <1473215632.11736.21.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi CK, On Wed, 2016-09-07 at 10:33 +0800, CK Hu wrote: > Hi, YT: > > On Fri, 2016-09-02 at 19:24 +0800, YT Shen wrote: > > From: shaoming chen > > > > add dsi read/write commands for transfer function > > > > Signed-off-by: shaoming chen > > --- > > drivers/gpu/drm/mediatek/mtk_dsi.c | 188 +++++++++++++++++++++++++++++++++++++ > > 1 file changed, 188 insertions(+) > > > > [snip...] > > > > > +static void mtk_dsi_irq_data_clear(struct mtk_dsi *dsi, u32 irq_bit) > > +{ > > + dsi->irq_data &= ~irq_bit; > > +} > > + > > [snip...] > > > + > > +static s32 mtk_dsi_wait_for_irq_done(struct mtk_dsi *dsi, u32 irq_flag, > > + unsigned int timeout) > > +{ > > + s32 ret = 0; > > + unsigned long jiffies = msecs_to_jiffies(timeout); > > + > > + ret = wait_event_interruptible_timeout(_dsi_irq_wait_queue, > > + dsi->irq_data & irq_flag, > > + jiffies); > > + if (ret == 0) { > > + dev_info(dsi->dev, "Wait DSI IRQ(0x%08x) Timeout\n", irq_flag); > > + > > + mtk_dsi_enable(dsi); > > + mtk_dsi_reset_engine(dsi); > > + } > > + > > + return ret; > > +} > > I think mtk_dsi_irq_data_clear() and mtk_dsi_wait_for_irq_done() should > be moved to the 6th patch [1] of this series because these two functions > deal the irq control. We will move mtk_dsi_irq_data_clear() to patch "drm/mediatek: add dsi interrupt control" and put mtk_dsi_wait_for_irq_done() here, because it is used in the transfer function. Regards, yt.shen > > > [1] https://patchwork.kernel.org/patch/9310819/ > > > Regards, > CK >