From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: axp2xx: disable ldoio0/1 at boot
Date: Mon, 12 Sep 2016 13:41:43 +0100 [thread overview]
Message-ID: <1473684103.28111.66.camel@hellion.org.uk> (raw)
In-Reply-To: <20160912075533.30299-1-hdegoede@redhat.com>
On Mon, 2016-09-12 at 09:55 +0200, Hans de Goede wrote:
> @@ -223,7 +223,14 @@ int axp_init(void)
> > ? if (!(axp_chip_id == 0x6 || axp_chip_id == 0x7 || axp_chip_id == 0x17))
> > ? return -ENODEV;
> ?
> > - return 0;
> > + /*
> > + ?* Turn off LDOIO regulators / tri-state GPIO pins, when rebooting
> > + ?* from android these are sometimes on.
> > + ?*/
> > + ret |= pmic_bus_write(AXP_GPIO0_CTRL, AXP_GPIO_CTRL_INPUT);
> > + ret |= pmic_bus_write(AXP_GPIO1_CTRL, AXP_GPIO_CTRL_INPUT);
If ret values are errno's (as the context suggests by containing
-ENODEV) then or-ing them together could result in corruption from
combining two distinct errno values.
Ian.
next prev parent reply other threads:[~2016-09-12 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 7:55 [U-Boot] [PATCH] sunxi: axp2xx: disable ldoio0/1 at boot Hans de Goede
2016-09-12 12:41 ` Ian Campbell [this message]
2016-09-12 13:24 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473684103.28111.66.camel@hellion.org.uk \
--to=ijc+uboot@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.