From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757049AbcILReg (ORCPT ); Mon, 12 Sep 2016 13:34:36 -0400 Received: from smtprelay0092.hostedemail.com ([216.40.44.92]:54491 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756706AbcILRe0 (ORCPT ); Mon, 12 Sep 2016 13:34:26 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3743:3865:3867:3868:3871:3873:4321:5007:8660:10004:10400:10848:11026:11658:11914:12043:12438:12740:12760:13069:13095:13148:13153:13228:13230:13311:13357:13439:13972:14096:14097:14181:14659:14721:21080:21095:21212:21324:21433:21451:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: club77_60c396e3a0d18 X-Filterd-Recvd-Size: 2538 Message-ID: <1473701663.11006.19.camel@perches.com> Subject: Re: [PATCH] tracing/syscalls: add in missing white space in error message text From: Joe Perches To: Colin King Cc: linux-kernel@vger.kernel.org Date: Mon, 12 Sep 2016 10:34:23 -0700 In-Reply-To: <20160912114127.30980-1-colin.king@canonical.com> References: <20160912114127.30980-1-colin.king@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-09-12 at 12:41 +0100, Colin King wrote: > pr_info message spans two lines and the literal string is missing > a white space between words. Add the white space. Perhaps better would be to coalesce the format string fragments. And if you didn't already know, checkpatch can find potential defects like this using --types=split_string,missing_space For instance: $ ./scripts/checkpatch.pl --show-types --types=split_string,missing_space --terse --no-summary \ -f kernel/trace/trace_syscalls.c kernel/trace/trace_syscalls.c:614: WARNING:SPLIT_STRING: quoted string split across lines kernel/trace/trace_syscalls.c:614: WARNING:MISSING_SPACE: break quoted strings at a space character kernel/trace/trace_syscalls.c:686: WARNING:SPLIT_STRING: quoted string split across lines kernel/trace/trace_syscalls.c:686: WARNING:MISSING_SPACE: break quoted strings at a space character > diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c [] > @@ -610,7 +610,7 @@ static int perf_sysenter_enable(struct trace_event_call *call) > if (!sys_perf_refcount_enter) > ret = register_trace_sys_enter(perf_syscall_enter, NULL); > if (ret) { > - pr_info("event trace: Could not activate" > + pr_info("event trace: Could not activate " > "syscall entry trace point"); > } else { > set_bit(num, enabled_perf_enter_syscalls); > @@ -682,7 +682,7 @@ static int perf_sysexit_enable(struct trace_event_call *call) > if (!sys_perf_refcount_exit) > ret = register_trace_sys_exit(perf_syscall_exit, NULL); > if (ret) { > - pr_info("event trace: Could not activate" > + pr_info("event trace: Could not activate " > "syscall exit trace point"); > } else { > set_bit(num, enabled_perf_exit_syscalls);