From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dalessandro, Dennis" Subject: Re: [PATCH] IB/rdmavt: free the userspace memory region with kfree instead of vfree Date: Tue, 13 Sep 2016 12:44:28 +0000 Message-ID: <1473770664.1004.10.camel@intel.com> References: <20160909071537.18821-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160909071537.18821-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> Content-Language: en-US Content-ID: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org" , "hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "Hefty, Sean" Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org T24gRnJpLCAyMDE2LTA5LTA5IGF0IDA4OjE1ICswMTAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gVGhl IHVzZXJzcGFjZSBtZW1vcnkgcmVnaW9uICdtcicgaXMgYWxsb2NhdGVkIHdpdGgga3phbGxvYyBp bg0KPiBfX3J2dF9hbGxvY19tcsKgwqBob3dldmVyIGl0IGlzIGluY29ycmVjdGx5IGJlaW5nIGZy ZWVkIHdpdGggdmZyZWUgaW4NCj4gX19ydnRfZnJlZV9tci4gRml4IHRoaXMgYnkgdXNpbmcga2Zy ZWUgdG8gZnJlZSBpdC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IENvbGluIElhbiBLaW5nIDxjb2xp bi5raW5nQGNhbm9uaWNhbC5jb20+DQo+IC0tLQ0KPiDCoGRyaXZlcnMvaW5maW5pYmFuZC9zdy9y ZG1hdnQvbXIuYyB8IDIgKy0NCj4gwqAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEg ZGVsZXRpb24oLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcmRt YXZ0L21yLmMNCj4gYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcmRtYXZ0L21yLmMNCj4gaW5kZXgg ODBjNGI2Yi4uNDZiNjQ5NyAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3Jk bWF2dC9tci5jDQo+ICsrKyBiL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yZG1hdnQvbXIuYw0KPiBA QCAtMjk0LDcgKzI5NCw3IEBAIHN0YXRpYyB2b2lkIF9fcnZ0X2ZyZWVfbXIoc3RydWN0IHJ2dF9t ciAqbXIpDQo+IMKgew0KPiDCoAlydnRfZGVpbml0X21yZWdpb24oJm1yLT5tcik7DQo+IMKgCXJ2 dF9mcmVlX2xrZXkoJm1yLT5tcik7DQo+IC0JdmZyZWUobXIpOw0KPiArCWtmcmVlKG1yKTsNCj4g wqB9DQo+IMKgDQo+IMKgLyoqDQoNClRoYW5rcyENCg0KQWNrZWQtYnk6IERlbm5pcyBEYWxlc3Nh bmRybyA8ZGVubmlzLmRhbGVzc2FuZHJvQGludGVsLmNvbT4= -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755963AbcIMMof (ORCPT ); Tue, 13 Sep 2016 08:44:35 -0400 Received: from mga14.intel.com ([192.55.52.115]:44103 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbcIMMoc (ORCPT ); Tue, 13 Sep 2016 08:44:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,328,1470726000"; d="scan'208";a="1049605465" From: "Dalessandro, Dennis" To: "colin.king@canonical.com" , "hal.rosenstock@gmail.com" , "linux-rdma@vger.kernel.org" , "dledford@redhat.com" , "Hefty, Sean" CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] IB/rdmavt: free the userspace memory region with kfree instead of vfree Thread-Topic: [PATCH] IB/rdmavt: free the userspace memory region with kfree instead of vfree Thread-Index: AQHSCmo2cGwgjgoVok6N5cRo6oW9d6B3yN0A Date: Tue, 13 Sep 2016 12:44:28 +0000 Message-ID: <1473770664.1004.10.camel@intel.com> References: <20160909071537.18821-1-colin.king@canonical.com> In-Reply-To: <20160909071537.18821-1-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.187.219] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u8DCielU022821 On Fri, 2016-09-09 at 08:15 +0100, Colin King wrote: > From: Colin Ian King > > The userspace memory region 'mr' is allocated with kzalloc in > __rvt_alloc_mr  however it is incorrectly being freed with vfree in > __rvt_free_mr. Fix this by using kfree to free it. > > Signed-off-by: Colin Ian King > --- >  drivers/infiniband/sw/rdmavt/mr.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/sw/rdmavt/mr.c > b/drivers/infiniband/sw/rdmavt/mr.c > index 80c4b6b..46b6497 100644 > --- a/drivers/infiniband/sw/rdmavt/mr.c > +++ b/drivers/infiniband/sw/rdmavt/mr.c > @@ -294,7 +294,7 @@ static void __rvt_free_mr(struct rvt_mr *mr) >  { >   rvt_deinit_mregion(&mr->mr); >   rvt_free_lkey(&mr->mr); > - vfree(mr); > + kfree(mr); >  } >   >  /** Thanks! Acked-by: Dennis Dalessandro