From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ewan D. Milne" Subject: Re: [PATCH] scsi: do not print 'reservation conflict' for TEST UNIT READY Date: Tue, 13 Sep 2016 15:05:40 -0400 Message-ID: <1473793540.4648.36.camel@localhost.localdomain> References: <1473668453-115818-1-git-send-email-hare@suse.de> <1473775496.2214.6.camel@HansenPartnership.com> <18995c82-c3b1-89f1-9336-dafe9169963c@suse.de> <1473779178.2214.9.camel@HansenPartnership.com> Reply-To: emilne@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44926 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759618AbcIMTFm (ORCPT ); Tue, 13 Sep 2016 15:05:42 -0400 In-Reply-To: <1473779178.2214.9.camel@HansenPartnership.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Hannes Reinecke , "Martin K. Petersen" , Christoph Hellwig , linux-scsi@vger.kernel.org, Hannes Reinecke On Tue, 2016-09-13 at 08:06 -0700, James Bottomley wrote: > On Tue, 2016-09-13 at 16:24 +0200, Hannes Reinecke wrote: > > On 09/13/2016 04:04 PM, James Bottomley wrote: > > > You could argue that the entire message needs removing, since it's > > > reporting stuff that mostly only shows when systems using > > > reservations correctly are in operation. > > > > > Oh, I'm perfectly fine with that. > > I'm happy to send a patch removing that line altogether. > > OK, how about lowering the priority to KERN_DEBUG so it can still be > seen, just not usually. > > James > So, if we do this, and someone else does a SCSI-2 RESERVE on the LUN while we have a file system mounted, what error will we end up getting? I would assume that we would still see the usual SCSI error message with the CDB printed, and that the "reservation conflict" message was supplemental? Or does the message get suppressed? I'll have to try this... -Ewan