From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762857AbcINONi (ORCPT ); Wed, 14 Sep 2016 10:13:38 -0400 Received: from smtprelay0221.hostedemail.com ([216.40.44.221]:48391 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754281AbcINONf (ORCPT ); Wed, 14 Sep 2016 10:13:35 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::,RULES_HIT:41:152:355:379:541:599:960:967:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2197:2199:2393:2525:2553:2561:2564:2682:2685:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3653:3743:3865:3867:3868:3870:3871:3872:3873:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4559:5007:6119:7809:7875:9010:9025:10004:10400:10471:10848:11232:11658:11914:12043:12109:12114:12296:12555:12740:13071:13161:13229:13255:13894:14180:14181:14659:14721:21060:21080:21221:21433:21451:30003:30022:30054:30060:30083:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: cart48_3c10971721328 X-Filterd-Recvd-Size: 2988 Message-ID: <1473862411.32273.25.camel@perches.com> Subject: Re: get_maintainer.pl and git send-email: 5.1.2 The recipient address is not a valid From: Joe Perches To: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Linux Kernel Mailing List Date: Wed, 14 Sep 2016 07:13:31 -0700 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-09-14 at 12:45 +0200, Rafał Miłecki wrote: > Hi Joe, Hello Rafał > Some time ago I started using git send-email with --cc-cmd and > get_maintainer.pl. I liked it and it worked fine until I tried to send > ubifs patch patch. I got this: > Send this email? ([y]es|[n]o|[q]uit|[a]ll): y > > 5.1.2 The recipient address is not a valid > 5.1.2 RFC-5321 address. j11sm4705544lfe.27 - gsmtp > > I suspect there may be some problem with MAINTAINERS entries using braces. > > Could you take a look at following try? > https://patchwork.ozlabs.org/patch/669853/ > > wget -O mtd.patch https://patchwork.ozlabs.org/patch/669853/mbox/ > git send-email --cc-cmd="scripts/get_maintainer.pl" mtd.patch > > It results in: > > (cc-cmd) Adding cc: linux-mtd@lists.infradead.org (open list:UBI FILE > SYSTEM (UBIFS)) from: 'scripts/get_maintainer.pl' > and Cc-ing: > linux-mtd@lists.infradead.org) (open list:UBI FILE SYSTEM (UBIFS) > > Is this something to fix at get_maintainer.pl level? Not really. At a minimum you need to add "--norolestats" to the cc-cmd invocation --cc-cmd="./scripts/get_maintainer.pl --norolestats" I use scripts to do this along with .gitconfig entries. [sendemail] chainreplyto = false thread = false suppresscc = self cccmd = ~/bin/cc.sh tocmd = ~/bin/to.sh The scripts use --to-cmd to address the direct maintainers and cc-cmd to address indirect maintainers and mailing lists. $ cat ~/bin/to.sh #!/bin/bash opts="--nogit --nogit-fallback --norolestats --pattern-depth=1" if [[ $(basename $1) =~ ^0000- ]] ; then ./scripts/get_maintainer.pl --nom $opts $(dirname $1)/* else maint=$(./scripts/get_maintainer.pl --nol $opts $1) if [ "$maint" == "" ] ; then echo "linux-kernel@vger.kernel.org" else echo "$maint" fi fi $ cat ~/bin/cc.sh #!/bin/bash opts="--nogit --nogit-fallback --norolestats" if [[ $(basename $1) =~ ^0000- ]] ; then ./scripts/get_maintainer.pl --nom $opts $(dirname $1)/* else ./scripts/get_maintainer.pl $opts $1 fi