From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 1/5] tegra: usb gadget: fix ci udc operation if not hostpc capable
Date: Wed, 14 Sep 2016 14:45:37 +0000 [thread overview]
Message-ID: <1473864336.14918.10.camel@toradex.com> (raw)
In-Reply-To: <fa7085b3-5e49-f09d-72cf-41320adadfb1@wwwdotorg.org>
On Mon, 2016-09-12 at 12:13 -0600, Stephen Warren wrote:
> On 09/09/2016 10:10 AM, Marcel Ziswiler wrote:
> >
> > The Tegra 2 aka T20 is not host PC capable. Therefore move the
> > define
> > CONFIG_CI_UDC_HAS_HOSTPC from the generic tegra-common-usb-gadget.h
> > header file into resp. SoC type specific ones.
> This is OK, but ...
>
> >
> > diff --git a/include/configs/tegra-common-usb-gadget.h
> > b/include/configs/tegra-common-usb-gadget.h
> >
> > ?#ifndef CONFIG_SPL_BUILD
> > ?/* USB gadget mode support*/
> > -#define CONFIG_CI_UDC_HAS_HOSTPC
> ... it seems a bit simpler to just wrap that in #ifndef
> CONFIG_TEGRA20.
>
> That would avoid having to duplicate the define in all tegra*-
> common.h?
> forever. Still, it's not a huge deal.
Agreed, I will change this in a v2.
next prev parent reply other threads:[~2016-09-14 14:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 16:10 [U-Boot] [PATCH v1 0/5] various fixes mainly for colibri_t20 Marcel Ziswiler
2016-09-09 16:10 ` [U-Boot] [PATCH v1 1/5] tegra: usb gadget: fix ci udc operation if not hostpc capable Marcel Ziswiler
2016-09-12 18:13 ` Stephen Warren
2016-09-14 14:45 ` Marcel Ziswiler [this message]
2016-09-09 16:10 ` [U-Boot] [PATCH v1 2/5] simple panel: fix spelling of debug message Marcel Ziswiler
2016-09-09 16:16 ` Anatolij Gustschin
2016-09-09 16:10 ` [U-Boot] [PATCH v1 3/5] colibri_t20: fix display configuration Marcel Ziswiler
2016-09-12 18:18 ` Stephen Warren
2016-09-14 15:20 ` Marcel Ziswiler
2016-09-14 17:19 ` Stephen Warren
2016-09-14 21:44 ` Marcel Ziswiler
2016-09-09 16:10 ` [U-Boot] [PATCH v1 4/5] colibri_t20: fix usb operation and controller order Marcel Ziswiler
2016-09-12 18:20 ` Stephen Warren
2016-09-14 15:34 ` Marcel Ziswiler
2016-09-09 16:10 ` [U-Boot] [PATCH v1 5/5] colibri_t20: enable dfu also for nand Marcel Ziswiler
2016-09-12 18:24 ` Stephen Warren
2016-09-14 15:41 ` Marcel Ziswiler
2016-09-14 17:23 ` Stephen Warren
2016-09-14 21:22 ` Marcel Ziswiler
2016-09-12 18:13 ` [U-Boot] [PATCH v1 0/5] various fixes mainly for colibri_t20 Stephen Warren
2016-09-14 15:45 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473864336.14918.10.camel@toradex.com \
--to=marcel.ziswiler@toradex.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.