From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkICL-00087f-Hq for qemu-devel@nongnu.org; Wed, 14 Sep 2016 17:58:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkICH-0008GT-TK for qemu-devel@nongnu.org; Wed, 14 Sep 2016 17:58:28 -0400 Received: from smtp2-g21.free.fr ([2a01:e0c:1:1599::11]:21603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkICH-0008GI-Nl for qemu-devel@nongnu.org; Wed, 14 Sep 2016 17:58:25 -0400 From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Wed, 14 Sep 2016 23:57:45 +0200 Message-Id: <1473890265-3304-6-git-send-email-hpoussin@reactos.org> In-Reply-To: <1473890265-3304-1-git-send-email-hpoussin@reactos.org> References: <1473890265-3304-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 5/5] ps2: do not generate invalid key codes for unknown keys List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?UTF-8?q?Herv=C3=A9=20Poussineau?= Instead, print a warning message. Signed-off-by: Herv=C3=A9 Poussineau --- hw/input/ps2.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index 3d7205d..5acd3ed 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -605,7 +605,8 @@ static void ps2_keyboard_event(DeviceState *dev, Qemu= Console *src, } ps2_put_keycode(s, keycode & 0xff); } else { - ps2_queue(&s->common, key->down ? 0x00 : 0x80); + qemu_log_mask(LOG_UNIMP, + "ps2: ignoring key with qcode %d\n", qcode= ); } } } else if (s->scancode_set =3D=3D 2) { @@ -644,13 +645,9 @@ static void ps2_keyboard_event(DeviceState *dev, Qem= uConsole *src, ps2_put_keycode(s, 0xf0); } ps2_put_keycode(s, keycode & 0xff); - } else if (key->down) { - ps2_queue(&s->common, 0x00); - } else if (s->translate) { - ps2_queue(&s->common, 0x80); } else { - ps2_queue(&s->common, 0xf0); - ps2_queue(&s->common, 0x00); + qemu_log_mask(LOG_UNIMP, + "ps2: ignoring key with qcode %d\n", qcode= ); } } } else if (s->scancode_set =3D=3D 3) { @@ -661,13 +658,9 @@ static void ps2_keyboard_event(DeviceState *dev, Qem= uConsole *src, ps2_put_keycode(s, 0xf0); } ps2_put_keycode(s, keycode); - } else if (key->down) { - ps2_queue(&s->common, 0x00); - } else if (s->translate) { - ps2_queue(&s->common, 0x80); } else { - ps2_queue(&s->common, 0xf0); - ps2_queue(&s->common, 0x00); + qemu_log_mask(LOG_UNIMP, + "ps2: ignoring key with qcode %d\n", qcode); } } } --=20 2.1.4