From: Joe Perches <joe@perches.com>
To: Josh Triplett <josh@joshtriplett.org>,
Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>, Greg KH <greg@kroah.com>,
Jonathan Corbet <corbet@lwn.net>, "Theodore Ts'o" <tytso@mit.edu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Minimize checkpatch induced patches...
Date: Wed, 14 Sep 2016 17:05:09 -0700 [thread overview]
Message-ID: <1473897909.32273.57.camel@perches.com> (raw)
In-Reply-To: <20160914235405.GB12672@cloud>
On Wed, 2016-09-14 at 16:54 -0700, Josh Triplett wrote:
> On Wed, Sep 14, 2016 at 07:56:55PM +0200, Christian Borntraeger wrote:
> > On 09/14/2016 07:51 PM, Joe Perches wrote:
> > > checkpatch can be a useful tool for patches.
> > >
> > > It can be a much more controversial tool when used on files with the
> > > -f option for style and whitespace changes for code that is relatively
> > > stable, obsolete, or for maintained by specific individuals.
[]
> > This will certainly help to reduce the noise. On the other hand I remember Linus
> > saying something along the line that he does not like the -f parameter (and he
> > prefers to set this automatically). So while I like the approach I am not happy
> > enough to ack right now - still looking for a better alternative :-/
> This seems entirely compatible with autodetection. If checkpatch
> detects that it runs on a file rather than a patch, it can assume -f.
> It can then apply this same logic to reject that if 1) in a kernel tree
> and 2) running on a non-staging file and 3) not passed --force.
checkpatch doesn't do autodetection and there's no real
need for it to do it either. The reason is in the name.
get_maintainer does.
next prev parent reply other threads:[~2016-09-15 0:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 17:51 [PATCH] checkpatch: Minimize checkpatch induced patches Joe Perches
2016-09-14 17:56 ` Christian Borntraeger
2016-09-14 18:06 ` Joe Perches
2016-09-14 18:16 ` Christian Borntraeger
2016-09-14 18:21 ` Joe Perches
2016-09-14 18:24 ` Christian Borntraeger
2016-09-14 18:33 ` Greg KH
2016-09-14 18:54 ` Christian Borntraeger
2016-09-14 19:09 ` Joe Perches
2016-09-18 19:38 ` Christian Borntraeger
2016-09-14 23:54 ` Josh Triplett
2016-09-15 0:05 ` Joe Perches [this message]
2016-09-15 0:09 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473897909.32273.57.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=borntraeger@de.ibm.com \
--cc=corbet@lwn.net \
--cc=greg@kroah.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.