Re: [Qemu-devel] [PATCH v4 3/3] target-ppc: tlbie/tlbivax should have global effect

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]

On Thu, 2016-09-15 at 10:25 +1000, David Gibson wrote:
> >  void helper_booke206_tlbivax(CPUPPCState *env, target_ulong
> address)
> >  {
> > -    PowerPCCPU *cpu = ppc_env_get_cpu(env);
> > +    CPUState *cs;
> >  
> >      if (address & 0x4) {
> >          /* flush all entries */
> > @@ -2774,11 +2774,15 @@ void helper_booke206_tlbivax(CPUPPCState
> *env, target_ulong address)
> >      if (address & 0x8) {
> >          /* flush TLB1 entries */
> >          booke206_invalidate_ea_tlb(env, 1, address);
> > -        tlb_flush(CPU(cpu), 1);
> > +        CPU_FOREACH(cs) {
> > +            tlb_flush(cs, 1);
> > +        }
> >      } else {
> >          /* flush TLB0 entries */
> >          booke206_invalidate_ea_tlb(env, 0, address);
> > -        tlb_flush_page(CPU(cpu), address & MAS2_EPN_MASK);
> > +        CPU_FOREACH(cs) {
> > +            tlb_flush_page(cs, address & MAS2_EPN_MASK);
> > +        }
> 
> Why are these explicit CPU_FOREACH()s instead of using the flags
> you've just bui

Because we haven't converted BookE to lazy TLB flushing yet...

Cheers,
Ben.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 855 bytes --]