From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757638AbcIPOLn (ORCPT ); Fri, 16 Sep 2016 10:11:43 -0400 Received: from p3plsmtps2ded03.prod.phx3.secureserver.net ([208.109.80.60]:43374 "EHLO p3plsmtps2ded03.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934982AbcIPOLP (ORCPT ); Fri, 16 Sep 2016 10:11:15 -0400 x-originating-ip: 72.167.245.219 From: kys@exchange.microsoft.com To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, leann.ogasawara@canonical.com Cc: "K. Y. Srinivasan" Subject: [PATCH 1/2] Drivers: hv: make VMBus bus ids persistent Date: Fri, 16 Sep 2016 09:01:17 -0700 Message-Id: <1474041678-17701-2-git-send-email-kys@exchange.microsoft.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1474041678-17701-1-git-send-email-kys@exchange.microsoft.com> References: <1474041638-17658-1-git-send-email-kys@exchange.microsoft.com> <1474041678-17701-1-git-send-email-kys@exchange.microsoft.com> Reply-To: kys@microsoft.com X-CMAE-Envelope: MS4wfDAIDbz8ZK+lEcuxMlxEQ6SsNyHu/EVsmsNKpZbvHns+psinx9a5EipxvwyRF8Z3fRbKGGplbs41HqldjffmlyeSErfSNgNptrn6tPcb4V0QEj/lHGiE MFB8irPv7Sh91aW0qaDBuit6z3S3u2znoXM4zcIWPBGp12a19/U23NofRLV6s1+DSazSgrTheZeghIT5Wu/0cxFG+1zRp8PmR7POmFGWvIUx6/tjt4/sagj3 5Zag8VZ7O5OBySn6+PcuzbLi8QtNRv3dEU6uMsu2/y4rSz2/mnMYArhRWLkHutEZ23ihndayWl8Tr3YN1w6vDOlT2pUNE9J2d2esNyXzymR0vUlZnyR3+eH4 TYoIEPMi6eeQZsVK0kF30ogqP3+uOk7sJz0x+BhVEV1hTIsC13KDRCxdR3oAdaUa0SaYxN3YnLyDfZID4o+gk5UnG82yxMIAK+ER1j1N9TZuBaDszQI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vitaly Kuznetsov Some tools use bus ids to identify devices and they count on the fact that these ids are persistent across reboot. This may be not true for VMBus as we use auto incremented counter from alloc_channel() as such id. Switch to using if_instance from channel offer, this id is supposed to be persistent. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/vmbus_drv.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index 6cbe074..a259e18 100644 --- a/drivers/hv/vmbus_drv.c +++ b/drivers/hv/vmbus_drv.c @@ -961,8 +961,8 @@ int vmbus_device_register(struct hv_device *child_device_obj) { int ret = 0; - dev_set_name(&child_device_obj->device, "vmbus_%d", - child_device_obj->channel->id); + dev_set_name(&child_device_obj->device, "vmbus-%pUl", + child_device_obj->channel->offermsg.offer.if_instance.b); child_device_obj->device.bus = &hv_bus; child_device_obj->device.parent = &hv_acpi_dev->dev; -- 1.7.4.1