All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ajay Bhargav <ajay.bhargav@einfochips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 1/2] gpio: Add GPIO driver framework for Marvell SoCs
Date: Thu, 11 Aug 2011 10:37:23 +0530 (IST)	[thread overview]
Message-ID: <1474045321.77841.1313039243899.JavaMail.root@ahm.einfochips.com> (raw)
In-Reply-To: <CALZhoSRXuAyUmHbdi2zjKNcuitB3aO=CUKrqVaPwgh_GWWYNFA@mail.gmail.com>


----- "Lei Wen" <adrian.wenl@gmail.com> wrote:
> 
> You should remove these two define, or we would met build error as:
> cmd_gpio.c:20: error: expected identifier before numeric constant
> cmd_gpio.c: In function 'do_gpio':
> cmd_gpio.c:49: error: 'GPIO_CLEAR' undeclared (first use in this
> function)
> cmd_gpio.c:49: error: (Each undeclared identifier is reported only
> once
> cmd_gpio.c:49: error: for each function it appears in.)
> cmd_gpio.c:50: error: 'GPIO_TOGGLE' undeclared (first use in this
> function)
> 
> Except this, other looks good to me, and I have verify the reset of
> patch on mmp3 board.
> 
> Thanks,
> Lei
> 
Hi Lei,

Thank you so much for pointing out. I tested library by simply defining
MARVELL_GPIO, I forgot to test with CMD_GPIO.

I will change the names and resubmit. sorry for mistake.

Thanks & Regards,
Ajay Bhargav

      reply	other threads:[~2011-08-11  5:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10 11:34 [U-Boot] [PATCH v5 1/2] gpio: Add GPIO driver framework for Marvell SoCs Ajay Bhargav
2011-08-10 11:48 ` Prafulla Wadaskar
2011-08-10 13:58 ` Lei Wen
2011-08-11  5:07   ` Ajay Bhargav [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474045321.77841.1313039243899.JavaMail.root@ahm.einfochips.com \
    --to=ajay.bhargav@einfochips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.