From: Johannes Berg <johannes@sipsolutions.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
Thomas Graf <tgraf@suug.ch>,
tom@herbertland.com
Subject: Re: [PATCH 0/2] rhashtable: rhashtable with duplicate objects
Date: Mon, 19 Sep 2016 10:58:55 +0200 [thread overview]
Message-ID: <1474275535.4469.14.camel@sipsolutions.net> (raw)
In-Reply-To: <20160919083518.GA11821@gondor.apana.org.au>
> > I take that back. I think it's leaking memory - my tests never used
> > to run out of memory, but now they eventually do.
>
> > I'll try to figure out more.
>
> Interesting. The kernel test robot found a bug in the insertion
> slowpath where we end up inserting without taking the inner spinlock
> in case of a nested table. Not sure whether that's the same issue
> as you're seeing but I'll do a v2 posting.
Increasing the memory for the VMs from 384MB to 512MB didn't avoid the
issue, so there's a definite leak somewhere, although this time fewer
VMs crashed :)
Reverting the patches and running with 384MB then works, so it's not
something else added in the meantime (I ran last a few days ago, but
don't think I merged anything interesting in the meantime).
I'll test your new patches in a minute.
johannes
next prev parent reply other threads:[~2016-09-19 8:59 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 7:18 Buggy rhashtable walking Herbert Xu
2016-08-04 7:18 ` Herbert Xu
2016-08-04 7:45 ` Herbert Xu
2016-08-04 7:45 ` Herbert Xu
2016-08-05 6:16 ` Johannes Berg
2016-08-05 10:48 ` Herbert Xu
2016-08-05 10:48 ` Herbert Xu
2016-08-05 10:50 ` Johannes Berg
2016-08-05 11:46 ` Ben Greear
2016-08-08 15:26 ` Herbert Xu
2016-08-08 15:26 ` Herbert Xu
2016-09-18 13:50 ` [PATCH 0/2] rhashtable: rhashtable with duplicate objects Herbert Xu
2016-09-18 13:50 ` Herbert Xu
2016-09-18 13:53 ` [PATCH 1/2] rhashtable: Add rhlist interface Herbert Xu
2016-09-18 13:53 ` Herbert Xu
2016-09-18 13:54 ` [PATCH 2/2] mac80211: Use rhltable instead of rhashtable Herbert Xu
2016-09-18 13:54 ` Herbert Xu
2016-09-19 8:20 ` [PATCH 0/2] rhashtable: rhashtable with duplicate objects Johannes Berg
2016-09-19 8:25 ` Johannes Berg
2016-09-19 8:35 ` Herbert Xu
2016-09-19 8:35 ` Herbert Xu
2016-09-19 8:58 ` Johannes Berg [this message]
2016-09-19 8:40 ` [v2 PATCH " Herbert Xu
2016-09-19 8:42 ` [v2 PATCH 1/2] rhashtable: Add rhlist interface Herbert Xu
2016-09-19 8:42 ` [v2 PATCH 2/2] mac80211: Use rhltable instead of rhashtable Herbert Xu
2016-09-19 8:42 ` Herbert Xu
2016-09-19 9:15 ` [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects Johannes Berg
2016-09-19 9:17 ` Herbert Xu
2016-09-19 9:17 ` Herbert Xu
2016-09-19 9:27 ` Johannes Berg
2016-09-19 9:31 ` Johannes Berg
2016-09-19 9:34 ` Herbert Xu
2016-09-19 9:34 ` Herbert Xu
2016-09-19 9:38 ` Johannes Berg
2016-09-19 9:38 ` Johannes Berg
2016-09-19 9:50 ` Johannes Berg
2016-09-19 9:54 ` Johannes Berg
2016-09-19 9:54 ` Johannes Berg
2016-09-19 10:02 ` Johannes Berg
2016-09-19 10:02 ` Johannes Berg
2016-09-19 10:04 ` Johannes Berg
2016-09-19 10:04 ` Johannes Berg
2016-09-19 10:10 ` Johannes Berg
2016-09-19 10:10 ` Johannes Berg
2016-09-19 10:48 ` Herbert Xu
2016-09-19 10:58 ` Johannes Berg
2016-09-19 10:58 ` Johannes Berg
2016-09-19 10:58 ` [v3 " Herbert Xu
2016-09-19 10:58 ` Herbert Xu
2016-09-19 11:00 ` [v3 PATCH 1/2] rhashtable: Add rhlist interface Herbert Xu
2016-09-19 11:00 ` Herbert Xu
2016-09-19 21:16 ` Thomas Graf
2016-09-20 1:52 ` Herbert Xu
2016-09-19 11:00 ` [v3 PATCH 2/2] mac80211: Use rhltable instead of rhashtable Herbert Xu
2016-09-19 11:03 ` [v3 PATCH 0/2] rhashtable: rhashtable with duplicate objects Johannes Berg
2016-09-19 11:32 ` Johannes Berg
2016-09-19 11:32 ` Johannes Berg
2016-09-20 8:44 ` David Miller
2016-09-20 8:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474275535.4469.14.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.