From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
Brian King <brking@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org, krisman@linux.vnet.ibm.com,
wenxiong@linux.vnet.ibm.com, stable@vger.kernel.org
Subject: Re: [RESEND] [PATCH 1/1] ses: Retry UNIT ATTENTION for receive diagnostics
Date: Mon, 19 Sep 2016 09:20:34 -0700 [thread overview]
Message-ID: <1474302034.2398.4.camel@HansenPartnership.com> (raw)
In-Reply-To: <yq1eg4fann1.fsf@sermon.lab.mkp.net>
On Mon, 2016-09-19 at 11:57 -0400, Martin K. Petersen wrote:
> > > > > > "Brian" == Brian King <brking@linux.vnet.ibm.com> writes:
>
> Brian> If the ses driver receives a UNIT ATTENTION when issuing a
> Brian> receive diagnostics while probing a SES device, it fails to
> Brian> attach with messages such as:
>
> Brian> scsi 1:0:7:0: Failed to get diagnostic page 0x8000002 scsi
> Brian> 1:0:7:0: Failed to bind enclosure -19
>
> Brian> Fix this by eating unit attentions for these commands.
>
> James?
It seems to me that UA handling should be a part of scsi_execute_req
(and scsi_execute) ... that is unless anyone can find a caller that
would actually be interested. I've been looking but haven't found one
so far.
James
next prev parent reply other threads:[~2016-09-19 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 21:06 [RESEND] [PATCH 1/1] ses: Retry UNIT ATTENTION for receive diagnostics Brian King
2016-09-16 21:25 ` Gabriel Krisman Bertazi
2016-09-19 15:57 ` Martin K. Petersen
2016-09-19 16:20 ` James Bottomley [this message]
2016-09-19 17:14 ` Ewan D. Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474302034.2398.4.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=brking@linux.vnet.ibm.com \
--cc=krisman@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
--cc=wenxiong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.