From: <gregkh@linuxfoundation.org>
To: pbonzini@redhat.com, gregkh@linuxfoundation.org,
matt@codeblueprint.co.uk
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "Revert "KVM: x86: fix missed hardware breakpoints"" has been added to the 4.4-stable tree
Date: Tue, 20 Sep 2016 14:10:51 +0200 [thread overview]
Message-ID: <147437345119587@kroah.com> (raw)
In-Reply-To: <1473976363-22653-1-git-send-email-pbonzini@redhat.com>
This is a note to let you know that I've just added the patch titled
Revert "KVM: x86: fix missed hardware breakpoints"
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
revert-kvm-x86-fix-missed-hardware-breakpoints.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From pbonzini@redhat.com Tue Sep 20 14:08:11 2016
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu, 15 Sep 2016 23:52:43 +0200
Subject: Revert "KVM: x86: fix missed hardware breakpoints"
To: stable@vger.kernel.org
Cc: matt@codeblueprint.co.uk, Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <1473976363-22653-1-git-send-email-pbonzini@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
[the change is part of 70e4da7a8ff62f2775337b705f45c804bb450454, which
is already in stable kernels 4.1.y to 4.4.y. this part of the fix
however was later undone, so remove the line again]
The following patches were applied in the wrong order in -stable. This
is the order as they appear in Linus' tree,
[0] commit 4e422bdd2f84 ("KVM: x86: fix missed hardware breakpoints")
[1] commit 172b2386ed16 ("KVM: x86: fix missed hardware breakpoints")
[2] commit 70e4da7a8ff6 ("KVM: x86: fix root cause for missed hardware breakpoints")
but this is the order for linux-4.4.y
[1] commit fc90441e728a ("KVM: x86: fix missed hardware breakpoints")
[2] commit 25e8618619a5 ("KVM: x86: fix root cause for missed hardware breakpoints")
[0] commit 0f6e5e26e68f ("KVM: x86: fix missed hardware breakpoints")
The upshot is that KVM_DEBUGREG_RELOAD is always set when returning
from kvm_arch_vcpu_load() in stable, but not in Linus' tree.
This happened because [0] and [1] are the same patch. [0] and [1] come from two
different merges, and the later merge is trivially resolved; when [2]
is applied it reverts both of them. Instead, when using the [1][2][0]
order, patches applies normally but "KVM: x86: fix missed hardware
breakpoints" is present in the final tree.
Reported-by: Matt Fleming <matt@codeblueprint.co.uk>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
arch/x86/kvm/x86.c | 1 -
1 file changed, 1 deletion(-)
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -2735,7 +2735,6 @@ void kvm_arch_vcpu_load(struct kvm_vcpu
}
kvm_make_request(KVM_REQ_STEAL_UPDATE, vcpu);
- vcpu->arch.switch_db_regs |= KVM_DEBUGREG_RELOAD;
}
void kvm_arch_vcpu_put(struct kvm_vcpu *vcpu)
Patches currently in stable-queue which might be from pbonzini@redhat.com are
queue-4.4/mips-kvm-check-for-pfn-noslot-case.patch
queue-4.4/revert-kvm-x86-fix-missed-hardware-breakpoints.patch
prev parent reply other threads:[~2016-09-20 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 21:52 [PATCH] Revert "KVM: x86: fix missed hardware breakpoints" Paolo Bonzini
[not found] ` <20160918004441.GA16340@sasha-lappy>
2016-09-18 12:38 ` Paolo Bonzini
2016-09-20 12:10 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=147437345119587@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=matt@codeblueprint.co.uk \
--cc=pbonzini@redhat.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.