From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] DRBG: fix bit shifting on 32 bit systems
Date: Tue, 26 Aug 2014 09:37:13 +0200 [thread overview]
Message-ID: <1474386.ELDQfGhIun@myon.chronox.de> (raw)
In-Reply-To: <20140826073219.GA3880@gondor.apana.org.au>
Am Dienstag, 26. August 2014, 15:32:19 schrieb Herbert Xu:
Hi Herbert,
> On Tue, Aug 26, 2014 at 09:31:02AM +0200, Stephan Mueller wrote:
> > Use ULL to mark a 64 bit value.
> >
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > Signed-off-by: Stephan Mueller <smueller@chronox.de>
>
> I don't think this works as size_t is still 32-bit which means
> that you'll return zero.
Oops, yes. Thank you for catching this. I guess I need __u64 for this value. A
patch will come shortly.
>
> Cheers,
--
Ciao
Stephan
next prev parent reply other threads:[~2014-08-26 7:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 6:14 linux-next: build warnings after merge of the crypto tree Stephen Rothwell
2014-08-26 6:38 ` Herbert Xu
2014-08-26 7:00 ` Stephan Mueller
2014-08-26 7:31 ` [PATCH] DRBG: fix bit shifting on 32 bit systems Stephan Mueller
2014-08-26 7:32 ` Herbert Xu
2014-08-26 7:37 ` Stephan Mueller [this message]
2014-08-26 8:06 ` [PATCH] DRBG: fix maximum value checks " Stephan Mueller
2014-08-26 8:08 ` Herbert Xu
2014-08-26 8:29 ` [PATCH v2] " Stephan Mueller
2014-08-26 8:43 ` Herbert Xu
2014-08-26 8:52 ` Stephan Mueller
2014-08-26 8:58 ` Herbert Xu
2014-08-26 9:36 ` Stephan Mueller
2014-08-27 13:35 ` Herbert Xu
2014-08-27 13:40 ` Stephan Mueller
2014-08-28 7:13 ` Stephan Mueller
2014-08-28 7:17 ` DRBG: remove test for uninitialized DRBG handle Stephan Mueller
2014-09-01 5:11 ` [PATCH v2] DRBG: remove check " Stephan Mueller
2014-09-03 1:33 ` Stephan Mueller
2014-09-03 23:21 ` Herbert Xu
2014-09-03 23:50 ` Stephan Mueller
2014-09-05 7:55 ` Herbert Xu
2014-09-05 11:25 ` Stephan Mueller
2014-09-05 8:13 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474386.ELDQfGhIun@myon.chronox.de \
--to=smueller@chronox.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.