From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34787)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1bmdPn-0007PE-C4
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 05:02:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1bmdPm-00023c-E9
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 05:02:03 -0400
Message-ID: <1474448505.2857.116.camel@kernel.crashing.org>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Wed, 21 Sep 2016 19:01:45 +1000
In-Reply-To: <BACE3833-EEA7-4D95-94E3-BC1447D5B0AB@gmail.com>
References: <5766C91B-319D-46CD-9020-19EB5299DF99@gmail.com>
	<1474266273.2857.11.camel@kernel.crashing.org>
	<852E4EA6-522A-499D-88DE-A1955D938D6D@gmail.com>
	<1474325083.2857.35.camel@kernel.crashing.org>
	<A448AD30-0D40-4C20-8424-74DF53521F20@gmail.com>
	<1474417098.2857.96.camel@kernel.crashing.org>
	<149AE2FD-4392-4F5F-A0AD-6613F5C47168@gmail.com>
	<1474418502.2857.97.camel@kernel.crashing.org>
	<BACE3833-EEA7-4D95-94E3-BC1447D5B0AB@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Add resolutions via the command-line
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: G 3 <programmingkidx@gmail.com>, The OpenBIOS Mailinglist <openbios@openbios.org>
Cc: qemu-devel qemu-devel <qemu-devel@nongnu.org>, "list@suse.de:PowerPC
	list:PowerPC" <qemu-ppc@nongnu.org>

On Tue, 2016-09-20 at 22:54 -0400, G 3 wrote:
> You really want to remove the included list of resolutions? I was=C2=A0=
=C2=A0
> thinking about adding a lot more built-in resolutions in another=C2=A0=C2=
=A0
> patch. A built-in list is very convenient.

I mean remove it from the driver and put it in OpenBIOS instead.

Ie. have openbios build the resolution list from the combination of what =
you put
in the options node and its own built-in list.

> As for the options node problem. We need a way to add resolutions=C2=A0=
=C2=A0
> from the command-line for a Mac OS X guest. Using "-prom-env" isn't=C2=A0=
=C2=A0
> an option because of some unknown bug.

Maybe, I can look into it later, but the above would fix it nicely.

>  I suppose it is possible to=C2=A0=C2=A0
> fix this bug - if it is a bug. Another idea I have is to add a=C2=A0=C2=
=A0
> completely different command-line option to QEMU just for=C2=A0=C2=A0
> resolutions. The user could specify resolutions like this: -video-=C2=A0
> resolutions 640x480,1024x768,1280x700.... This feature could place=C2=A0=
=C2=A0
> the list of resolutions inside a property of the VGA device node. I=C2=A0=
=C2=A0
> am betting the VGA driver could access this node and parse the list=C2=A0=
=C2=A0
> of resolutions. So this: qemu -video-resolutions ---> OpenBIOS VGA=C2=A0=
=C2=A0
> device node ---> VGA driver
>=20
> Would anyone have another idea they would like to share?

As I said. Have OpenBIOS build the list of resolutions and put it in a
property (in binary, not ASCII form so the driver doesn't have to do
the mess it does now) in the DT node of the device itself.

Cheers,
Ben.