From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmdQc-0007qT-FO for qemu-devel@nongnu.org; Wed, 21 Sep 2016 05:02:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmdQb-0002HQ-IP for qemu-devel@nongnu.org; Wed, 21 Sep 2016 05:02:54 -0400 Message-ID: <1474448559.2857.118.camel@kernel.crashing.org> From: Benjamin Herrenschmidt Date: Wed, 21 Sep 2016 19:02:39 +1000 In-Reply-To: <20160921031809.GT20488@umbus> References: <20160814225339.482797.79805@ex-std-node742.prod.rhcloud.com> <1471219193.12231.78.camel@kernel.crashing.org> <1471219913.12231.80.camel@kernel.crashing.org> <20160921031809.GT20488@umbus> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, famz@redhat.com On Wed, 2016-09-21 at 13:18 +1000, David Gibson wrote: > > There are actually a couple of places where I agree with the style > > change, so I'll include that in a futher post after more useful > review > > has been posted (seriously, stylebots are just infuriating). >=20 > So.. as irritating as you find the bot, there are a bunch of > gratuitous style problems.=C2=A0 In particular sungem.c itself isn't > consistent about whether it has 8 char or 4 char indentation.=C2=A0 Tha= t > really does need to be fixed. No time to work on this now. I will try to get back on to it later but I'm happy for anybody to pick it up if they want to. Cheers, Ben.