From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmexE-00008O-Gg for qemu-devel@nongnu.org; Wed, 21 Sep 2016 06:40:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmexC-0006ef-C2 for qemu-devel@nongnu.org; Wed, 21 Sep 2016 06:40:39 -0400 Message-ID: <1474454419.2857.122.camel@kernel.crashing.org> From: Benjamin Herrenschmidt Date: Wed, 21 Sep 2016 20:40:19 +1000 In-Reply-To: <87intpblrm.fsf@linaro.org> References: <20160814225339.482797.79805@ex-std-node742.prod.rhcloud.com> <1471219193.12231.78.camel@kernel.crashing.org> <87intpblrm.fsf@linaro.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex =?ISO-8859-1?Q?Benn=E9e?= Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, famz@redhat.com On Wed, 2016-09-21 at 11:16 +0100, Alex Benn=C3=A9e wrote: >=C2=A0 > > >=20 > > > total: 428 errors, 73 warnings, 1950 lines checked > > >=20 > > > Your patch has style problems, please review.If any of these > > > errors > > > are false positives report them to the maintainer, see > > > CHECKPATCH in MAINTAINERS. >=20 > It seems very unlikely all of the reported errors here can be > justified > along the lines of internal consistency, especially for adding a new > file. It's actually an old thread ;-) I've already fixed some of these, just haven't had a chance to finish and submit a new version. However *most* of the above are intentional and I won't fix, it's about the .h file describing the registers that is essentially lifted from Linux and that I want to keep largely identical for obvious reasons (thus including the use of tabs). Cheers, Ben.