From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH v3 6/9] drm/i915/skl+: change WM calc to fixed point 16.16 Date: Wed, 21 Sep 2016 15:32:20 -0300 Message-ID: <1474482740.2593.15.camel@intel.com> References: <20160909080106.17506-1-mahesh1.kumar@intel.com> <20160909080106.17506-7-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5FE0B6E2D0 for ; Wed, 21 Sep 2016 18:32:25 +0000 (UTC) In-Reply-To: <20160909080106.17506-7-mahesh1.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Kumar, Mahesh" , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGkKCkVtIFNleCwgMjAxNi0wOS0wOSDDoHMgMTM6MzEgKzA1MzAsIEt1bWFyLCBNYWhlc2ggZXNj cmV2ZXU6Cj4gRnJvbTogTWFoZXNoIEt1bWFyIDxtYWhlc2gxLmt1bWFyQGludGVsLmNvbT4KCkZp cnN0IG9mIGFsbCwgZ29vZCBjYXRjaCB3aXRoIHRoaXMgcGF0Y2ghCgo+IAo+IFRoaXMgcGF0Y2gg Y2hhbmdlcyBXYXRlcm1hayBjYWxjdWxhdGlvbiB0byBmaXhlZCBwb2ludCBjYWxjdWxhdGlvbi4K PiBQcm9ibGVtIHdpdGggY3VycmVudCBjYWxjdWxhdGlvbiBpcyBkdXJpbmcgcGxhbmVfYmxvY2tz X3Blcl9saW5lCj4gY2FsY3VsYXRpb24gd2UgZGl2aWRlIGludGVybWVkaWF0ZSBibG9ja3Mgd2l0 aCBtaW5fc2NhbmxpbmVzIGFuZAo+IHRha2VzIGZsb29yIG9mIHRoZSByZXN1bHQgYmVjYXVzZSBv ZiBpbnRlZ2VyIG9wZXJhdGlvbi4KPiBoZW5jZSB3ZSBlbmQtdXAgYXNzaWduaW5nIGxlc3MgYmxv Y2tzIHRoYW4gcmVxdWlyZWQuIFdoaWNoIGxlYWRzIHRvCj4gZmxpY2tlcnMuCgpUaGlzIHByb2Js ZW0gaXMgdGhhdCB0aGUgcGF0Y2ggZG9lc24ndCBvbmx5IGRvIHRoaXMuIEl0IGFsc28gdHJpZXMg dG8KbWFrZSB0aGUgbWV0aG9kMSByZXN1bHQgYmUgYSBmaXhlZCBwb2ludCAxNi4xNiwgYW5kIGl0 IGFsc28gZG9lcyBhCmNvbXBsZXRlbHkgdW5yZWxhdGVkIGNoYW5nZSB3aXRoIHRoZSBhZGRpdGlv biBvZiB0aGUgeV90aWxlZCB2YXJpYWJsZS4KSSdkIHJlYWxseSBsaWtlIG9mIHRoZSAzIGNoYW5n ZXMgd2VyZSAzIGRpZmZlcmVudCBwYXRjaGVzLgoKCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFoZXNo IEt1bWFyIDxtYWhlc2gxLmt1bWFyQGludGVsLmNvbT4KPiAtLS0KPiDCoGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3BtLmMgfCAyMyArKysrKysrKysrKysrKy0tLS0tLS0tLQo+IMKgMSBmaWxl IGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BtLmMKPiBpbmRleCAwZWMzMjhiLi5kNDM5MGU0IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9wbS5jCj4gQEAgLTM1MzAsMTMgKzM1MzAsMTUgQEAgc3RhdGljIHVpbnQzMl90IHNr bF9waXBlX3BpeGVsX3JhdGUoY29uc3QKPiBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY29uZmln KQo+IMKgKi8KPiDCoHN0YXRpYyB1aW50MzJfdCBza2xfd21fbWV0aG9kMSh1aW50MzJfdCBwaXhl bF9yYXRlLCB1aW50OF90IGNwcCwKPiB1aW50MzJfdCBsYXRlbmN5KQo+IMKgewo+IC0JdWludDMy X3Qgd21faW50ZXJtZWRpYXRlX3ZhbCwgcmV0Owo+ICsJdWludDY0X3Qgd21faW50ZXJtZWRpYXRl X3ZhbDsKPiArCXVpbnQzMl90IHJldDsKPiDCoAo+IMKgCWlmIChsYXRlbmN5ID09IDApCj4gwqAJ CXJldHVybiBVSU5UX01BWDsKPiDCoAo+IC0Jd21faW50ZXJtZWRpYXRlX3ZhbCA9IGxhdGVuY3kg KiBwaXhlbF9yYXRlICogY3BwIC8gNTEyOwo+IC0JcmV0ID0gRElWX1JPVU5EX1VQKHdtX2ludGVy bWVkaWF0ZV92YWwsIDEwMDApOwo+ICsJd21faW50ZXJtZWRpYXRlX3ZhbCA9IGxhdGVuY3kgKiBw aXhlbF9yYXRlICogY3BwOwo+ICsJd21faW50ZXJtZWRpYXRlX3ZhbCA8PD0gMTY7Cj4gKwlyZXQg PSBESVZfUk9VTkRfVVBfVUxMKHdtX2ludGVybWVkaWF0ZV92YWwsIDEwMDAgKiA1MTIpOwo+IMKg Cj4gwqAJcmV0dXJuIHJldDsKPiDCoH0KClNvIHNob3VsZG4ndCB3ZSBmaXggdGhlIGNhbGxlcnMg b2Ygc2tsX3dtX21ldGhvZDEgdG8gdGFrZSBpbnRvCmNvbnNpZGVyYXRpb24gdGhhdCB0aGUgdmFs dWUgcmV0dXJuZWQgaXMgbm93IGEgZml4ZWQgcG9pbnQgMTYuMTY/ClNvdW5kcyBsaWtlIHdlIGhh dmUgYSBidWcgaGVyZS4KCkFsc28sIGhhdmluZyBtZXRob2QxIGJlIDE2LjE2IGFuZCBtZXRob2Qy IGJlIGEgbm9ybWFsIGludGVnZXIgYWRkcyBhCmxvdCB0byB0aGUgY29uZnVzaW9uLgoKCj4gQEAg LTM2MDUsNiArMzYwNyw3IEBAIHN0YXRpYyBpbnQgc2tsX2NvbXB1dGVfcGxhbmVfd20oY29uc3Qg c3RydWN0Cj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gwqAJdWludDE2X3QgKm91dF9i bG9ja3MgPSAmcmVzdWx0LT5wbGFuZV9yZXNfYltpZF07Cj4gwqAJdWludDhfdCAqb3V0X2xpbmVz ID0gJnJlc3VsdC0+cGxhbmVfcmVzX2xbaWRdOwo+IMKgCWVudW0gd2F0ZXJtYXJrX21lbW9yeV93 YSBtZW1fd2E7Cj4gKwlib29sIHlfdGlsZWQgPSBmYWxzZTsKClBsZWFzZSBlaXRoZXIgZGlzY2Fy ZCB0aGVzZSB5X3RpbGVkIGNodW5rcyBvciBtb3ZlIHRoZW0gdG8gYSBzZXBhcmF0ZQpwYXRjaC4g QW5kIHNpbmNlIHdlIGhhdmUgdGhlIHlfdGlsZWQgdmFyaWFibGUsIG1heWJlIHdlJ2QgYWxzbyBs aWtlIHRvCmhhdmUgYW4geF90aWxlZCB2YXJpYWJsZSBmb3IgY29uc2lzdGVuY3kgYmV0d2VlbiB0 aGUgY2hlY2tzPwoKCj4gwqAKPiDCoAlpZiAobGF0ZW5jeSA9PSAwIHx8ICFjc3RhdGUtPmJhc2Uu YWN0aXZlIHx8ICFpbnRlbF9wc3RhdGUtCj4gPmJhc2UudmlzaWJsZSkKPiDCoAkJcmV0dXJuIDA7 Cj4gQEAgLTM2NTIsMTQgKzM2NTUsMTggQEAgc3RhdGljIGludCBza2xfY29tcHV0ZV9wbGFuZV93 bShjb25zdCBzdHJ1Y3QKPiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiDCoAlwbGFuZV9i eXRlc19wZXJfbGluZSA9IHdpZHRoICogY3BwOwo+IMKgCWlmIChmYi0+bW9kaWZpZXJbMF0gPT0g STkxNV9GT1JNQVRfTU9EX1lfVElMRUQgfHwKPiDCoAnCoMKgwqDCoGZiLT5tb2RpZmllclswXSA9 PSBJOTE1X0ZPUk1BVF9NT0RfWWZfVElMRUQpIHsKPiArCQl5X3RpbGVkID0gdHJ1ZTsKPiDCoAkJ cGxhbmVfYmxvY2tzX3Blcl9saW5lID0KPiDCoAkJwqDCoMKgwqDCoMKgRElWX1JPVU5EX1VQKHBs YW5lX2J5dGVzX3Blcl9saW5lICoKPiB5X21pbl9zY2FubGluZXMsIDUxMik7Cj4gLQkJcGxhbmVf YmxvY2tzX3Blcl9saW5lIC89IHlfbWluX3NjYW5saW5lczsKPiArCQlwbGFuZV9ibG9ja3NfcGVy X2xpbmUgPSAocGxhbmVfYmxvY2tzX3Blcl9saW5lIDw8Cj4gMTYpIC8KPiArCQkJCQkJCQl5X21p Cj4gbl9zY2FubGluZXM7Cj4gwqAJfSBlbHNlIGlmIChmYi0+bW9kaWZpZXJbMF0gPT0gRFJNX0ZP Uk1BVF9NT0RfTk9ORSkgewo+IMKgCQlwbGFuZV9ibG9ja3NfcGVyX2xpbmUgPQo+IERJVl9ST1VO RF9VUChwbGFuZV9ieXRlc19wZXJfbGluZSwgNTEyKQo+IMKgCQkJCQkrIDE7Cj4gKwkJcGxhbmVf YmxvY2tzX3Blcl9saW5lIDw8PSAxNjsKPiDCoAl9IGVsc2Ugewo+IMKgCQlwbGFuZV9ibG9ja3Nf cGVyX2xpbmUgPQo+IERJVl9ST1VORF9VUChwbGFuZV9ieXRlc19wZXJfbGluZSwgNTEyKTsKPiAr CQlwbGFuZV9ibG9ja3NfcGVyX2xpbmUgPDw9IDE2Owo+IMKgCX0KClRoaXMgaXMgcHJvYmFibHkg YSByZWJhc2UgcHJvYmxlbSwgYnV0IG5vdCBhbGwgcGxhY2VzIHdoZXJlCnBsYW5lX2Jsb2Nrc19w ZXJfbGluZSBhcmUgdXNlZCB3ZXJlIGZpeGVkIHRvIHRha2UgaW50byBjb25zaWRlcmF0aW9uCnRo ZSBuZXcgMTYuMTYgZm9ybWF0LgoKCk5vdywgd2hhdCBJJ3ZlIGJlZW4gdGhpbmtpbmcgaXMgdGhh dCB3ZSBjb21wbGV0ZWx5IGZhaWwgYXQgdHlwZS1zYWZldHkKd2hlbiB3ZSBtaXggdGhlc2Ugbm9y bWFsIGludGVnZXJzIHdpdGggdGhlIDE2LjE2IGludGVnZXJzLiBJZGVhbGx5LCB3ZQpzaG91bGQg ZmluZCBhIHdheSB0byBtYWtlIHRoZSBjb21waWxlciBjb21wbGFpbiBhYm91dCB0aGlzIHRvIHVz LCBzaW5jZQppdCdzIHRvbyBlYXN5IHRvIG1ha2Ugc3VjaCBtaXN0YWtlcy4gQ2FuJ3Qgd2UgdHJ5 IHRvIG1ha2UgdGhlIGNvbXBpbGVyCmhlbHAgdXMsIHN1Y2ggYXMgYnkgZGVmaW5pbmcgc29tZXRo aW5nIGxpa2UKCnR5cGVkZWYgc3RydWN0IHsKCXVpbnQzMl90IHZhbDsKfSB1aW50X2ZpeGVkXzE2 XzE2X3Q7CgphbmQgdGhlbiBtYWtpbmcgdGhlIGFwcHJvcHJpYXRlIGZ1bmN0aW9ucy9tYWNyb3Mg Zm9yIG1hbml1cGxhdGluZyB0aGVtCmFuZCBtaXhpbmcgdGhlbSB3aXRoIGludGVnZXJzPyBUaGlz IHdvdWxkIGhlbHAgY2F0Y2hpbmcgcHJvYmxlbXMgc3VjaAphcyB0aGUgb25lIHdlIGhhdmUgaGVy ZS4gQWxzbywgb3RoZXIgcGllY2VzIG9mIGk5MTUua28gYW5kIGRybS5rbyBjb3VsZApiZW5lZml0 IGZyb20gdGhpcy4KCj4gwqAKPiDCoAltZXRob2QxID0gc2tsX3dtX21ldGhvZDEocGxhbmVfcGl4 ZWxfcmF0ZSwgY3BwLCBsYXRlbmN5KTsKPiBAQCAtMzY3MCw4ICszNjc3LDcgQEAgc3RhdGljIGlu dCBza2xfY29tcHV0ZV9wbGFuZV93bShjb25zdCBzdHJ1Y3QKPiBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiwKPiDCoAo+IMKgCXlfdGlsZV9taW5pbXVtID0gcGxhbmVfYmxvY2tzX3Blcl9saW5l ICogeV9taW5fc2NhbmxpbmVzOwo+IMKgCj4gLQlpZiAoZmItPm1vZGlmaWVyWzBdID09IEk5MTVf Rk9STUFUX01PRF9ZX1RJTEVEIHx8Cj4gLQnCoMKgwqDCoGZiLT5tb2RpZmllclswXSA9PSBJOTE1 X0ZPUk1BVF9NT0RfWWZfVElMRUQpIHsKPiArCWlmICh5X3RpbGVkKSB7Cj4gwqAJCXNlbGVjdGVk X3Jlc3VsdCA9IG1heChtZXRob2QyLCB5X3RpbGVfbWluaW11bSk7Cj4gwqAJfSBlbHNlIHsKPiDC oAkJdWludDMyX3QgbGluZXRpbWVfdXMgPSAwOwo+IEBAIC0zNjg4LDEyICszNjk0LDExIEBAIHN0 YXRpYyBpbnQgc2tsX2NvbXB1dGVfcGxhbmVfd20oY29uc3Qgc3RydWN0Cj4gZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsCj4gwqAJCQlzZWxlY3RlZF9yZXN1bHQgPSBtZXRob2QxOwo+IMKgCX0K PiDCoAo+IC0JcmVzX2Jsb2NrcyA9IHNlbGVjdGVkX3Jlc3VsdCArIDE7Cj4gKwlyZXNfYmxvY2tz ID0gRElWX1JPVU5EX1VQKHNlbGVjdGVkX3Jlc3VsdCwgMSA8PCAxNikgKyAxOwo+IMKgCXJlc19s aW5lcyA9IERJVl9ST1VORF9VUChzZWxlY3RlZF9yZXN1bHQsCj4gcGxhbmVfYmxvY2tzX3Blcl9s aW5lKTsKPiDCoAo+IMKgCWlmIChsZXZlbCA+PSAxICYmIGxldmVsIDw9IDcpIHsKPiAtCQlpZiAo ZmItPm1vZGlmaWVyWzBdID09IEk5MTVfRk9STUFUX01PRF9ZX1RJTEVEIHx8Cj4gLQkJwqDCoMKg wqBmYi0+bW9kaWZpZXJbMF0gPT0gSTkxNV9GT1JNQVRfTU9EX1lmX1RJTEVEKSB7Cj4gKwkJaWYg KHlfdGlsZWQpIHsKPiDCoAkJCXJlc19ibG9ja3MgKz0geV90aWxlX21pbmltdW07Cj4gwqAJCQly ZXNfbGluZXMgKz0geV9taW5fc2NhbmxpbmVzOwo+IMKgCQl9IGVsc2UgewpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK