From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Roman Savchenko <gmstima@gmail.com>,
bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] bitbake: Correct broken symlink behaviour
Date: Fri, 23 Sep 2016 15:01:10 +0100 [thread overview]
Message-ID: <1474639270.7207.367.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAGpdKUJ0sctyDhyzSQq3wBCSG3T5ioRETApT7OzdvAvV4U5Xhg@mail.gmail.com>
Hi Roman,
On Fri, 2016-09-23 at 10:55 +0300, Roman Savchenko wrote:
> I adjusted commit message and function description. but I do not
> agree with proposed
> function name `create_valid_symlink`, becasue link creation could
> fail - so I left `try_symlink`
> to point this behaviour.
I don't agree with "try_symlink" though, sorry.
Link creation can fail but that is like any other function which can
also fail. We don't prefix all function names with try_ because they
can fail.
We need a better name.
Cheers,
Richard
next prev parent reply other threads:[~2016-09-23 14:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 16:23 [PATCH] bitbake: Correct broken symlink behaviour Roman Savchenko
2016-09-21 21:17 ` Richard Purdie
2016-09-23 7:45 ` Roman Savchenko
2016-09-23 7:55 ` Roman Savchenko
2016-09-23 14:01 ` Richard Purdie [this message]
2016-09-27 10:22 ` Roman Savchenko
2016-09-27 10:24 ` Roman Savchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474639270.7207.367.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=gmstima@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.