All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Medhurst (Tixy) <tixy@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] vexpress: disable cci ace slave ports when booting in non-sec/hyp mode
Date: Fri, 23 Sep 2016 17:03:17 +0100	[thread overview]
Message-ID: <1474646597.7095.20.camel@linaro.org> (raw)
In-Reply-To: <1474643401-13624-1-git-send-email-sudeep.holla@arm.com>

On Fri, 2016-09-23 at 16:10 +0100, Sudeep Holla wrote:
> +#ifdef CONFIG_OF_BOARD_SETUP
> +int ft_board_setup(void *fdt, bd_t *bd)
> +{
> +       int offset, tmp, len;
> +       const struct fdt_property *prop;
> +       const char *cci_compatible = "arm,cci-400-ctrl-if";
> +
> +       if (!armv7_boot_nonsec_default())
> +               return 0; /* Do nothing */
> +

That's just testing the default not whether the board is actually going
to boot in nonsec (hyp) mode or not, which also also depends on
environment variables. So you probably want instead to call
armv7_boot_nonsec() here. That function only exists if
CONFIG_ARMV7_NONSEC is defined, so the 'if' statement above probably
wants to be something like...

#ifdef CONFIG_ARMV7_NONSEC
	if (!armv7_boot_nonsec())
		return 0;
#else
	return 0;
#endif
	/* We only get here if board will boot in nonsec mode */

-- 
Tixy

  parent reply	other threads:[~2016-09-23 16:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-23 15:10 [U-Boot] [PATCH] vexpress: disable cci ace slave ports when booting in non-sec/hyp mode Sudeep Holla
2016-09-23 15:27 ` Marc Zyngier
2016-09-23 16:03 ` Jon Medhurst [this message]
2016-09-23 16:13   ` Sudeep Holla
2016-09-23 16:38 ` [U-Boot] [PATCH v2] " Sudeep Holla
2016-09-26 11:30   ` Jon Medhurst
2016-09-26 11:35     ` Sudeep Holla
2016-09-26 11:37       ` Sudeep Holla
2016-09-26 12:30   ` Jon Medhurst
2016-09-26 12:38     ` Sudeep Holla
2016-09-26 13:19       ` Jon Medhurst
2016-09-26 13:24         ` Sudeep Holla
2016-10-08 17:06   ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474646597.7095.20.camel@linaro.org \
    --to=tixy@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.