All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, amit.shah@redhat.com, quintela@redhat.com,
	michael@hinespot.com
Subject: [Qemu-devel] [PATCH 1/3] migration/rdma: Pass qemu_file errors across link
Date: Fri, 23 Sep 2016 20:14:02 +0100	[thread overview]
Message-ID: <1474658044-9479-2-git-send-email-dgilbert@redhat.com> (raw)
In-Reply-To: <1474658044-9479-1-git-send-email-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

If we fail for some reason (e.g. a mismatched RAMBlock)
and it's set the qemu_file error flag, pass that error back to the
peer so it can clean up rather than waiting for some higher level
progress.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 migration/rdma.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/migration/rdma.c b/migration/rdma.c
index 88bdb64..7271292 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -2804,6 +2804,9 @@ static int qio_channel_rdma_close(QIOChannel *ioc,
     QIOChannelRDMA *rioc = QIO_CHANNEL_RDMA(ioc);
     trace_qemu_rdma_close();
     if (rioc->rdma) {
+        if (!rioc->rdma->error_state) {
+            rioc->rdma->error_state = qemu_file_get_error(rioc->file);
+        }
         qemu_rdma_cleanup(rioc->rdma);
         g_free(rioc->rdma);
         rioc->rdma = NULL;
-- 
2.7.4

  reply	other threads:[~2016-09-23 19:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-23 19:14 [Qemu-devel] [PATCH 0/3] RDMA error handling Dr. David Alan Gilbert (git)
2016-09-23 19:14 ` Dr. David Alan Gilbert (git) [this message]
2016-09-23 19:14 ` [Qemu-devel] [PATCH 2/3] migration: Make failed migration load set file error Dr. David Alan Gilbert (git)
2016-09-23 19:14 ` [Qemu-devel] [PATCH 3/3] migration/rdma: Don't flag an error when we've been told about one Dr. David Alan Gilbert (git)
2016-09-23 19:22 ` [Qemu-devel] [PATCH 0/3] RDMA error handling Michael R. Hines
2016-09-26  7:49   ` Dr. David Alan Gilbert
2016-10-05  8:58 ` Juan Quintela
2016-10-05  9:07   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474658044-9479-2-git-send-email-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=michael@hinespot.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.