All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Anton Mitterer <calestyo@scientia.net>
To: linux-btrfs@vger.kernel.org
Subject: Re: Does data checksumming remain for files with No_COW file attribute?
Date: Sat, 24 Sep 2016 20:09:26 +0200	[thread overview]
Message-ID: <1474740566.7196.4.camel@scientia.net> (raw)
In-Reply-To: <20160924174012.51d44caa@natsu>

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

On Sat, 2016-09-24 at 17:40 +0500, Roman Mamedov wrote:
> Yes. IIRC the reasoning was that it's more difficult to track
> checksums of
> data which is being overwritten in-place (as opposed to CoW).
AFAIU it wouldn't be more difficult, since the meta-data itself is
still subject to CoW...

There's just no guarantee in the case of a crash, that checksum and
data match (which is IMO however a small price to pay - especially as
the data is in that case and without CoW anyway not guaranteed to be
valid - compared to all sorts of other silent corruptions against which
checksums protect... not to talk about the ability to actually repair
files in case of RAID inconsistencies.


> You can't apply chattr +C to any files of non-zero length, so by
> definition
> there won't be any pre-existing checksummed extents in that file.

Speaking of which,... can't one modify chattr properly so that it gives
an error message and $? != 0 in that case?


Cheers,
Chris.

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5930 bytes --]

  parent reply	other threads:[~2016-09-24 18:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-24 12:26 Does data checksumming remain for files with No_COW file attribute? Alexander Tomokhov
2016-09-24 12:37 ` Hugo Mills
2016-09-24 23:25   ` Alexander Tomokhov
2016-09-24 23:50     ` Adam Borowski
2016-09-25  5:44       ` Duncan
2016-09-26 20:41         ` Adam Borowski
2016-09-24 12:40 ` Roman Mamedov
2016-09-24 12:43   ` Hugo Mills
2016-09-24 18:11     ` Christoph Anton Mitterer
2016-09-25 13:49       ` Goffredo Baroncelli
2016-09-25 19:53         ` Christoph Anton Mitterer
2016-09-26 11:11       ` Austin S. Hemmelgarn
2016-09-24 18:09   ` Christoph Anton Mitterer [this message]
2016-09-24 21:44     ` Adam Borowski
2016-09-24 22:52       ` Christoph Anton Mitterer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474740566.7196.4.camel@scientia.net \
    --to=calestyo@scientia.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.