From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:60918 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031482AbcIZJsG (ORCPT ); Mon, 26 Sep 2016 05:48:06 -0400 Subject: Patch "kbuild: forbid kernel directory to contain spaces and colons" has been added to the 4.4-stable tree To: robert.jarzmik@free.fr, gregkh@linuxfoundation.org, mmarek@suse.com Cc: , From: Date: Mon, 26 Sep 2016 11:47:54 +0200 Message-ID: <14748832741490@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled kbuild: forbid kernel directory to contain spaces and colons to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: kbuild-forbid-kernel-directory-to-contain-spaces-and-colons.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 51193b76bfff5027cf96ba63effae808ad67cca7 Mon Sep 17 00:00:00 2001 From: Robert Jarzmik Date: Sat, 2 Apr 2016 21:38:53 +0200 Subject: kbuild: forbid kernel directory to contain spaces and colons From: Robert Jarzmik commit 51193b76bfff5027cf96ba63effae808ad67cca7 upstream. When the kernel path contains a space or a colon somewhere in the path name, the modules_install target doesn't work anymore, as the path names are not enclosed in double quotes. It is also supposed that and O= build will suffer from the same weakness as modules_install. Instead of checking and improving kbuild to resist to directories including these characters, error out early to prevent any build if the kernel's main directory contains a space. Signed-off-by: Robert Jarzmik Signed-off-by: Michal Marek Signed-off-by: Greg Kroah-Hartman --- Makefile | 4 ++++ 1 file changed, 4 insertions(+) --- a/Makefile +++ b/Makefile @@ -128,6 +128,10 @@ _all: # Cancel implicit rules on top Makefile $(CURDIR)/Makefile Makefile: ; +ifneq ($(words $(subst :, ,$(CURDIR))), 1) + $(error main directory cannot contain spaces nor colons) +endif + ifneq ($(KBUILD_OUTPUT),) # Invoke a second make in the output directory, passing relevant variables # check that the output directory actually exists Patches currently in stable-queue which might be from robert.jarzmik@free.fr are queue-4.4/kbuild-forbid-kernel-directory-to-contain-spaces-and-colons.patch