From: Paulo Zanoni <paulo.r.zanoni@intel.com>
To: vathsala nagaraju <vathsala.nagaraju@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: don't report compression when fbc disabled
Date: Mon, 26 Sep 2016 15:20:29 -0300 [thread overview]
Message-ID: <1474914029.2861.5.camel@intel.com> (raw)
In-Reply-To: <1474534193-9527-1-git-send-email-vathsala.nagaraju@intel.com>
Em Qui, 2016-09-22 às 14:19 +0530, vathsala nagaraju escreveu:
> when i915_fbc_status is read while fbc is disabled,
> it reports compressing to be true, which is confusing.
> report compressing only when fbc is enabled.
>
> Signed-off-by: vathsala nagaraju <vathsala.nagaraju@intel.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> b/drivers/gpu/drm/i915/i915_debugfs.c
> index cfcc72e..fb10cfc 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1658,7 +1658,8 @@ static int i915_fbc_status(struct seq_file *m,
> void *unused)
> seq_printf(m, "FBC disabled: %s\n",
> dev_priv->fbc.no_fbc_reason);
>
> - if (INTEL_GEN(dev_priv) >= 7)
> + if (intel_fbc_is_active(dev_priv) &&
> + INTEL_GEN(dev_priv) >= 7)
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
I'll push this patch soon. Thanks for the patch!
> seq_printf(m, "Compressing: %s\n",
> yesno(I915_READ(FBC_STATUS2) &
> FBC_COMPRESSION_MASK));
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-09-26 18:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 8:49 [PATCH] drm/i915: don't report compression when fbc disabled vathsala nagaraju
2016-09-22 15:19 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-09-26 18:20 ` Paulo Zanoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474914029.2861.5.camel@intel.com \
--to=paulo.r.zanoni@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vathsala.nagaraju@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.