From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE Date: Tue, 27 Sep 2016 09:56:23 -0700 Message-ID: <1474995383.2731.17.camel@perches.com> References: <3187035019207d96dd8b290bbcce203a38e7d1d3.1474856262.git.joe@perches.com> <1474992297.2731.13.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Emil Velikov Cc: Daniel Vetter , Intel Graphics Development , Linux Kernel Mailing List , dri-devel List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyMDE2LTA5LTI3IGF0IDE3OjM2ICswMTAwLCBFbWlsIFZlbGlrb3Ygd3JvdGU6Cj4g T24gMjcgU2VwdGVtYmVyIDIwMTYgYXQgMTc6MDQsIEpvZSBQZXJjaGVzIDxqb2VAcGVyY2hlcy5j b20+IHdyb3RlOgo+ID4gT24gVHVlLCAyMDE2LTA5LTI3IGF0IDExOjU4IC0wNDAwLCBTZWFuIFBh dWwgd3JvdGU6Cj4gPiA+IE9uIFN1biwgU2VwIDI1LCAyMDE2IGF0IDEwOjE4IFBNLCBKb2UgUGVy Y2hlcyA8am9lQHBlcmNoZXMuY29tPiB3cm90ZToKPiA+ID4gPiBVc2UgYSBiaXQgbW9yZSBjb25z aXN0ZW50IHN0eWxlIHdpdGgga2VybmVsIGxvZ2xldmVscwo+ID4gPiBJJ20gbm90IGNvbnZpbmNl ZCB0aGlzIGlzIHdvcnRoIGRvaW5nIGlmIHdlJ3JlIGdvaW5nIHRvIGtlZXAgdGhlCj4gPiA+IFdB Uk4vV0FSTklORyBkaXNjcmVwYW5jeSwgYW5kIEkgZG9uJ3QgdGhpbmsgd2Ugc2hvdWxkIHN3aXRj aCBEUk1fV0FSTgo+ID4gPiB0byBEUk1fV0FSTklORyBzaW5jZSBpdCdzIHNvIHdpZGVseSB1c2Vk Lgo+ID4gVGhlcmUgaXMgbm8gRFJNX1dBUk4gaW5jb25zaXN0ZW5jeS4KPiBEUk1fV0FSTiBpcyB0 byBEUk1fV0FSTklORyBsaWtlIERSTV9JTkZPIGlzIHRvIERSTV9JTkZPUk1BVElPTiBhbmQKPiBE Uk1fTk9URSBpcyB0byBEUk1fTk9USUNFLi4uCgpEUk1fSU5GT1JNQVRJT04gZG9lc24ndCBleGlz dCBpbiB0aGUga2VybmVsIHRyZWUuCgo+IGlzIHdoYXQgSSdtIHRoaW5raW5nIGFuZCBzZWVtaW5n bHkgc28KPiBkb2VzIFNlYW4uIEZ3aXcgdGhhdCBwYXJ0IHNlZW0gY29zbWV0aWMvdW5yZWxhdGVk IHRvIHRoZSByZXN0IG9mIHRoZQo+IHBhdGNoLCBzbyBpdCBtaWdodCBiZSB3b3J0aCBrZWVwaW5n IHNlcGFyYXRlID8KClRvIG1lLCBzaW1wbGlmeWluZyB0aGUgbWFjcm8gbWVhbnMgdXNpbmcgdGhl IGNvbW1vbiBrZXJuZWwKbWFjcm8gZm9ybXMuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936347AbcI0Q4e (ORCPT ); Tue, 27 Sep 2016 12:56:34 -0400 Received: from smtprelay0031.hostedemail.com ([216.40.44.31]:56529 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935537AbcI0Q41 (ORCPT ); Tue, 27 Sep 2016 12:56:27 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:4321:5007:10004:10400:10848:11232:11658:11914:12296:12663:12740:12760:13069:13311:13357:13439:14096:14097:14181:14659:14721:21080:30054:30055:30060:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: year97_37f6214cc7307 X-Filterd-Recvd-Size: 2198 Message-ID: <1474995383.2731.17.camel@perches.com> Subject: Re: [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE From: Joe Perches To: Emil Velikov Cc: Sean Paul , Intel Graphics Development , Linux Kernel Mailing List , dri-devel , Daniel Vetter Date: Tue, 27 Sep 2016 09:56:23 -0700 In-Reply-To: References: <3187035019207d96dd8b290bbcce203a38e7d1d3.1474856262.git.joe@perches.com> <1474992297.2731.13.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-09-27 at 17:36 +0100, Emil Velikov wrote: > On 27 September 2016 at 17:04, Joe Perches wrote: > > On Tue, 2016-09-27 at 11:58 -0400, Sean Paul wrote: > > > On Sun, Sep 25, 2016 at 10:18 PM, Joe Perches wrote: > > > > Use a bit more consistent style with kernel loglevels > > > I'm not convinced this is worth doing if we're going to keep the > > > WARN/WARNING discrepancy, and I don't think we should switch DRM_WARN > > > to DRM_WARNING since it's so widely used. > > There is no DRM_WARN inconsistency. > DRM_WARN is to DRM_WARNING like DRM_INFO is to DRM_INFORMATION and > DRM_NOTE is to DRM_NOTICE... DRM_INFORMATION doesn't exist in the kernel tree. > is what I'm thinking and seemingly so > does Sean. Fwiw that part seem cosmetic/unrelated to the rest of the > patch, so it might be worth keeping separate ? To me, simplifying the macro means using the common kernel macro forms.