From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935158AbcI0RoA (ORCPT ); Tue, 27 Sep 2016 13:44:00 -0400 Received: from smtprelay0100.hostedemail.com ([216.40.44.100]:56084 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751302AbcI0Rnx (ORCPT ); Tue, 27 Sep 2016 13:43:53 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2740:2828:2898:3138:3139:3140:3141:3142:3352:3622:3865:3867:3871:4321:4385:5007:10004:10400:10848:11026:11232:11658:11914:12043:12048:12296:12438:12740:13069:13311:13357:13439:13894:14659:14721:21080:21324:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: knife52_21712cf541a5c X-Filterd-Recvd-Size: 1866 Message-ID: <1474998228.2731.18.camel@perches.com> Subject: Re: [PATCH] Staging: android: fix permissions style From: Joe Perches To: Ramiro Oliveira , gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 27 Sep 2016 10:43:48 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-09-26 at 22:02 +0100, Ramiro Oliveira wrote: > Change permissions from symbolic to octal. [] > diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c [] > @@ -204,10 +204,10 @@ device_initcall(lowmem_init); >   * not really modular, but the easiest way to keep compat with existing >   * bootargs behaviour is to continue using module_param here. >   */ > -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR); > +module_param_named(cost, lowmem_shrinker.seeks, int, 0644); >  module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, > >   S_IRUGO | S_IWUSR); >  module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size, >   S_IRUGO | S_IWUSR); Seems odd to fix the other two but not this one. > -module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR); > +module_param_named(debug_level, lowmem_debug_level, uint, 0644);