From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B7CFC433EF for ; Sun, 22 May 2022 14:00:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 159F083F33; Sun, 22 May 2022 16:00:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="M0WbRt+T"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 98DA183F72; Sun, 22 May 2022 15:59:59 +0200 (CEST) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C51D383EDA for ; Sun, 22 May 2022 15:59:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ed1-x52d.google.com with SMTP id i40so16074657eda.7 for ; Sun, 22 May 2022 06:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=AzIyhyELlhpN2l6wFVP+YYzI5LXiJUSGHGM98mN2+YQ=; b=M0WbRt+T5cg8EiDZbNKjYjZLko/Owzd8dZu+q0O/gwAQxHSytwrPwU9a4I0AMYFri1 leYWbmRV3OU4hkRn9L3a6jbB1hnQvoFSmNPzWo/tSt1ZWBargBQg48QYRCzJAvk71tV+ HQlo84A9C7cg/+jCNfHPIwBnorCRcGTQhLhUIyiiPXDugO9Rsc7GPQv/9gmNGUP6Tt1v ot9/aR9OZwfhzgN5UyMc4kfEO7VaFT96aNyy/nQQaM927VImt6m3mDn3D/eEPrsm7ReV vZ91aDT5MZGdMXzVGS8+bdizHSvzCCXTTeoe7XpLIMz/Amof1NAzRc4DHlfwj06uKrV2 uT7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=AzIyhyELlhpN2l6wFVP+YYzI5LXiJUSGHGM98mN2+YQ=; b=p56E0r7QmPyL66sFrwQTLsbxz3y/8cUjsXF6FbmBwRkK3ZmT8Yt9Jzdu3HshbpRumc 2P4rFOc+XU0dGaNJr1aT4w4iuLH2r42Of/37pro8BiP/mv5NBVX2JLHmw2VSbTf4MefN adPo2zMScM6icPy5xjTHHeCBLxKU8liVrHUGrSpdDioKaSkkYH0yv/B1Ic97lPTQwqGo 1uSJrqccUhxhUf2lwNPGH06BkewuxtMTzVzPBAZWHT778PXyP3+qMTAO5Oq+bhpV55CA rcU2DflEccBBEw5tZsMmpPqVznBQ4YdvdtC2NLseR03fY1T0gqYWx8fcrlFTItstcfpb TMVg== X-Gm-Message-State: AOAM531VNhyvKp+tBOHazg+Op1vR5h9fY/t6EdZFzkt4/9jLNPmXSj1A FuY7qOgwUNFeSYhyXi7eqBU= X-Google-Smtp-Source: ABdhPJzgokwXtD7eqrCdhwoSwtXnocIMdL5ThgWvJznlqI2F20QZcYO3dbILvzHo3tLBZ9r2ENnUOg== X-Received: by 2002:a05:6402:42d4:b0:416:5cac:a9a0 with SMTP id i20-20020a05640242d400b004165caca9a0mr19892220edc.86.1653227994415; Sun, 22 May 2022 06:59:54 -0700 (PDT) Received: from [192.168.0.74] ([178.233.178.185]) by smtp.gmail.com with ESMTPSA id p25-20020aa7c4d9000000b004278942f86asm7031488edr.7.2022.05.22.06.59.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 May 2022 06:59:53 -0700 (PDT) Message-ID: <1474d84b-6566-2e18-8c38-a85b90866364@gmail.com> Date: Sun, 22 May 2022 16:57:56 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 From: Alper Nebi Yasak Subject: Re: [PATCH V4 8/8] binman_sym: guard with CONFIG_SPL_BINMAN_SYMBOLS To: "Peng Fan (OSS)" Cc: u-boot@lists.denx.de, Peng Fan , sbabic@denx.de, festevam@gmail.com, ariel.dalessandro@collabora.com, michael@amarulasolutions.com, tharvey@gateworks.com, sjg@chromium.org, marek.behun@nic.cz, pali@kernel.org, sr@denx.de, ricardo@foundries.io, patrick.delaunay@foss.st.com, trini@konsulko.com References: <20220520141048.20034-1-peng.fan@oss.nxp.com> <20220520141048.20034-9-peng.fan@oss.nxp.com> Content-Language: en-US In-Reply-To: <20220520141048.20034-9-peng.fan@oss.nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 20/05/2022 17:10, Peng Fan (OSS) wrote: > From: Peng Fan > > There is case that CONFIG_BINMAN is defined, but > CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case, there will be > build failure. So use CONFIG_SPL_BINMAN_SYMBOLS to guard the macros, and > define CONFIG_SPL_BINMAN_SYMBOLS in binman syms test. I guess they should be CONFIG_IS_ENABLED(BINMAN_SYMBOLS) instead, as there's also a CONFIG_TPL_BINMAN_SYMBOLS. > > Tested-by: Tim Harvey #imx8m[m,n,p]-venice > Signed-off-by: Peng Fan > --- > include/binman_sym.h | 2 +- > tools/binman/test/u_boot_binman_syms.c | 1 + > tools/binman/test/u_boot_binman_syms_size.c | 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/binman_sym.h b/include/binman_sym.h > index 72e6765fe52..548d8f5654c 100644 > --- a/include/binman_sym.h > +++ b/include/binman_sym.h > @@ -13,7 +13,7 @@ > > #define BINMAN_SYM_MISSING (-1UL) > > -#ifdef CONFIG_BINMAN > +#ifdef CONFIG_SPL_BINMAN_SYMBOLS > > /** > * binman_symname() - Internal function to get a binman symbol name > diff --git a/tools/binman/test/u_boot_binman_syms.c b/tools/binman/test/u_boot_binman_syms.c > index 37fc339ce84..f4a4d1f6846 100644 > --- a/tools/binman/test/u_boot_binman_syms.c > +++ b/tools/binman/test/u_boot_binman_syms.c > @@ -6,6 +6,7 @@ > */ > > #define CONFIG_BINMAN > +#define CONFIG_SPL_BINMAN_SYMBOLS > #include > > binman_sym_declare(unsigned long, u_boot_spl_any, offset); > diff --git a/tools/binman/test/u_boot_binman_syms_size.c b/tools/binman/test/u_boot_binman_syms_size.c > index 7224bc1863c..3a01d8ca4be 100644 > --- a/tools/binman/test/u_boot_binman_syms_size.c > +++ b/tools/binman/test/u_boot_binman_syms_size.c > @@ -6,6 +6,7 @@ > */ > > #define CONFIG_BINMAN > +#define CONFIG_SPL_BINMAN_SYMBOLS > #include > > binman_sym_declare(char, u_boot_spl, pos);