All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Armin Kuster <akuster808@gmail.com>,
	akuster@mvista.com, bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] codeparser: Use hashlib for hashing, not hash()
Date: Wed, 28 Sep 2016 16:14:28 +0100	[thread overview]
Message-ID: <1475075668.30475.72.camel@linuxfoundation.org> (raw)
In-Reply-To: <1475075217-17547-1-git-send-email-akuster808@gmail.com>

On Wed, 2016-09-28 at 08:06 -0700, Armin Kuster wrote:
> From: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> "hash() is randomised by default each time you start a new instance
> of
> recent
> versions (Python3.3+) to prevent dictionary insertion DOS attacks"
> 
> which means we need to use hashlib.md5 to get consistent values for
> the codeparser cache under python 3. Prior to this, the codeparser
> cache was effectively useless under python3 as shown by performance
> regressions.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> (cherry picked from commit 12d43cf45ba48e3587392f15315d92a1a53482ef)
> 
> We kept running into an issue where shell scripts were not
> getting generated on 32bit hosts. It seemed to be caused by this
> code.

I'm puzzled. This patch is in master. I'm therefore assuming you're
suggesting this for 1.30 but it doesn't say that anywhere.

1.30 isn't python3 based and therefore doesn't have the problem
described above?

Cheers,

Richard



  reply	other threads:[~2016-09-28 15:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 15:06 [PATCH] codeparser: Use hashlib for hashing, not hash() Armin Kuster
2016-09-28 15:14 ` Richard Purdie [this message]
2016-09-28 15:25   ` akuster
2016-09-28 19:12     ` Christopher Larson
2016-09-28 19:18       ` akuster
  -- strict thread matches above, loose matches on Subject: below --
2016-06-03 12:34 Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475075668.30475.72.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=akuster808@gmail.com \
    --cc=akuster@mvista.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.