From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2665229277552603314==" MIME-Version: 1.0 From: Walker, Benjamin Subject: Re: [SPDK] Is there any plan to add "quirk" mechanism to SPDK? Date: Wed, 28 Sep 2016 16:33:25 +0000 Message-ID: <1475080403.99978.4.camel@intel.com> In-Reply-To: CAAZN+A2h7S-H50wFpYrVjHE9_exSW=9F=sQ5oZgowQSs6QygFQ@mail.gmail.com List-ID: To: spdk@lists.01.org --===============2665229277552603314== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable We'd love to have you submit a patch to make nvme_intel.c generic (nvme_qui= rks.c). Please go ahead. On Wed, 2016-09-28 at 10:16 +0800, Wang Weber wrote: Thanks for the information. Is there a plan to update nvme_intel.c to be geneirc? or may I modify it and upload the patch to the community? Thanks. 2016-09-13 0:20 GMT+08:00 Daniel Verkamp >: On 09/09/2016 11:03 AM, Walker, Benjamin wrote: Currently we have no mechanism for adding device-specific quirks to the SPDK NVMe driver. We'd certainly consider adding quirks in the same fashion as the Linux kernel driver though, and would welcome patches that improved the applicability of SPDK to a wider range of (potentially out of spec) devices. I'm sure over time the team at Intel working on SPDK will add this, but it is not on our immediate roadmap, so patches from the community would be the best way to get this going. Thanks, Ben The SPDK NVMe driver does have a quirk system that is currently used only for Intel-specific quirks (see lib/nvme/nvme_intel.c); however, the structure used just matches against a PCI device ID in a generic way, so we should be able to extend this for use with other devices. I think the ideal first patch to add such a quirk would be to rename the nvme_intel file and structures to be generic. Then we could add new quirk flags to describe whatever non-spec-compliant behavior is required to make these devices work. Thanks, -- Daniel _______________________________________________ SPDK mailing list SPDK(a)lists.01.org https://lists.01.org/mailman/listinfo/spdk _______________________________________________ SPDK mailing list SPDK(a)lists.01.org https://lists.01.org/mailman/listinfo/spdk --===============2665229277552603314== Content-Type: text/html MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.html" PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5Pg0KPGRpdj5XZSdkIGxv dmUgdG8gaGF2ZSB5b3Ugc3VibWl0IGEgcGF0Y2ggdG8gbWFrZSBudm1lX2ludGVsLmMgZ2VuZXJp YyAobnZtZV9xdWlya3MuYykuIFBsZWFzZSBnbyBhaGVhZC48L2Rpdj4NCjxkaXY+PGJyPg0KPC9k aXY+DQo8ZGl2Pk9uIFdlZCwgMjAxNi0wOS0yOCBhdCAxMDoxNiAmIzQzOzA4MDAsIFdhbmcgV2Vi ZXIgd3JvdGU6PC9kaXY+DQo8YmxvY2txdW90ZSB0eXBlPSJjaXRlIj4NCjxwcmU+VGhhbmtzIGZv ciB0aGUgaW5mb3JtYXRpb24uDQoNCklzIHRoZXJlIGEgcGxhbiB0byB1cGRhdGUgbnZtZV9pbnRl bC5jIHRvIGJlIGdlbmVpcmM/IG9yIG1heSBJIG1vZGlmeQ0KaXQgYW5kIHVwbG9hZCB0aGUgcGF0 Y2ggdG8gdGhlIGNvbW11bml0eT8gVGhhbmtzLg0KDQoyMDE2LTA5LTEzIDA6MjAgR01UJiM0Mzsw ODowMCBEYW5pZWwgVmVya2FtcCAmbHQ7PGEgaHJlZj0ibWFpbHRvOmRhbmllbC52ZXJrYW1wQGlu dGVsLmNvbSI+ZGFuaWVsLnZlcmthbXBAaW50ZWwuY29tPC9hPiZndDs6DQo8YmxvY2txdW90ZSB0 eXBlPSJjaXRlIj4NCk9uIDA5LzA5LzIwMTYgMTE6MDMgQU0sIFdhbGtlciwgQmVuamFtaW4gd3Jv dGU6DQo8YmxvY2txdW90ZSB0eXBlPSJjaXRlIj4NCg0KQ3VycmVudGx5IHdlIGhhdmUgbm8gbWVj aGFuaXNtIGZvciBhZGRpbmcgZGV2aWNlLXNwZWNpZmljIHF1aXJrcyB0byB0aGUNClNQREsgTlZN ZSBkcml2ZXIuIFdlJ2QgY2VydGFpbmx5IGNvbnNpZGVyIGFkZGluZyBxdWlya3MgaW4gdGhlIHNh bWUNCmZhc2hpb24gYXMgdGhlIExpbnV4IGtlcm5lbCBkcml2ZXIgdGhvdWdoLCBhbmQgd291bGQg d2VsY29tZSBwYXRjaGVzDQp0aGF0IGltcHJvdmVkIHRoZSBhcHBsaWNhYmlsaXR5IG9mIFNQREsg dG8gYSB3aWRlciByYW5nZSBvZiAocG90ZW50aWFsbHkNCm91dCBvZiBzcGVjKSBkZXZpY2VzLiBJ J20gc3VyZSBvdmVyIHRpbWUgdGhlIHRlYW0gYXQgSW50ZWwgd29ya2luZyBvbg0KU1BESyB3aWxs IGFkZCB0aGlzLCBidXQgaXQgaXMgbm90IG9uIG91ciBpbW1lZGlhdGUgcm9hZG1hcCwgc28gcGF0 Y2hlcw0KZnJvbSB0aGUgY29tbXVuaXR5IHdvdWxkIGJlIHRoZSBiZXN0IHdheSB0byBnZXQgdGhp cyBnb2luZy4NCg0KVGhhbmtzLA0KQmVuDQo8L2Jsb2NrcXVvdGU+DQoNCg0KVGhlIFNQREsgTlZN ZSBkcml2ZXIgZG9lcyBoYXZlIGEgcXVpcmsgc3lzdGVtIHRoYXQgaXMgY3VycmVudGx5IHVzZWQg b25seQ0KZm9yIEludGVsLXNwZWNpZmljIHF1aXJrcyAoc2VlIGxpYi9udm1lL252bWVfaW50ZWwu Yyk7IGhvd2V2ZXIsIHRoZQ0Kc3RydWN0dXJlIHVzZWQganVzdCBtYXRjaGVzIGFnYWluc3QgYSBQ Q0kgZGV2aWNlIElEIGluIGEgZ2VuZXJpYyB3YXksIHNvIHdlDQpzaG91bGQgYmUgYWJsZSB0byBl eHRlbmQgdGhpcyBmb3IgdXNlIHdpdGggb3RoZXIgZGV2aWNlcy4NCg0KSSB0aGluayB0aGUgaWRl YWwgZmlyc3QgcGF0Y2ggdG8gYWRkIHN1Y2ggYSBxdWlyayB3b3VsZCBiZSB0byByZW5hbWUgdGhl DQpudm1lX2ludGVsIGZpbGUgYW5kIHN0cnVjdHVyZXMgdG8gYmUgZ2VuZXJpYy4gIFRoZW4gd2Ug Y291bGQgYWRkIG5ldyBxdWlyaw0KZmxhZ3MgdG8gZGVzY3JpYmUgd2hhdGV2ZXIgbm9uLXNwZWMt Y29tcGxpYW50IGJlaGF2aW9yIGlzIHJlcXVpcmVkIHRvIG1ha2UNCnRoZXNlIGRldmljZXMgd29y ay4NCg0KVGhhbmtzLA0KLS0gRGFuaWVsDQoNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fDQpTUERLIG1haWxpbmcgbGlzdA0KPGEgaHJlZj0ibWFpbHRvOlNQ REtAbGlzdHMuMDEub3JnIj5TUERLQGxpc3RzLjAxLm9yZzwvYT4NCjxhIGhyZWY9Imh0dHBzOi8v bGlzdHMuMDEub3JnL21haWxtYW4vbGlzdGluZm8vc3BkayI+aHR0cHM6Ly9saXN0cy4wMS5vcmcv bWFpbG1hbi9saXN0aW5mby9zcGRrPC9hPg0KPC9ibG9ja3F1b3RlPg0KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NClNQREsgbWFpbGluZyBsaXN0DQo8YSBo cmVmPSJtYWlsdG86U1BES0BsaXN0cy4wMS5vcmciPlNQREtAbGlzdHMuMDEub3JnPC9hPg0KPGEg aHJlZj0iaHR0cHM6Ly9saXN0cy4wMS5vcmcvbWFpbG1hbi9saXN0aW5mby9zcGRrIj5odHRwczov L2xpc3RzLjAxLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3NwZGs8L2E+DQo8L3ByZT4NCjwvYmxvY2tx dW90ZT4NCjwvYm9keT4NCjwvaHRtbD4NCg== --===============2665229277552603314==--