diff for duplicates of <1475108451.2405.6.camel@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 35a4d7d..ecc5ec6 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -29,10 +29,10 @@ On Wed, 2016-09-28 at 12:18 +0200, Thomas Huth wrote: > features", &plen); > + assert(prop != NULL); > + -> + if (plen >= 26 && prop->data[1] = 0 && (prop->data[24] & +> + if (plen >= 26 && prop->data[1] == 0 && (prop->data[24] & > 0x80) != 0) -If you're checking prop->data[1] = 0 to verify device tree consistency -then maybe it's worth checking that plen = prop->data[0] as well. +If you're checking prop->data[1] == 0 to verify device tree consistency +then maybe it's worth checking that plen == prop->data[0] as well. Although in the current state these are hard coded into qemu and unlikely to ever be wrong it's probably nice to check. @@ -51,7 +51,7 @@ else than anything actually wrong with the test. > + > + ret = dt_for_each_cpu_node(cpu_has_tm, &available); > + -> + return ret = 0 && available = nr_cpus; +> + return ret == 0 && available == nr_cpus; > +} > > static int h_cede(void) @@ -66,7 +66,7 @@ else than anything actually wrong with the test. > + if (!i) > + return report_summary(); > + -> all = argc = 1 || !strcmp(argv[1], "all"); +> all = argc == 1 || !strcmp(argv[1], "all"); > > for (i = 0; hctests[i].name != NULL; i++) { Thanks for adding this check, didn't cross my mind when implementing diff --git a/a/content_digest b/N1/content_digest index da0b082..d4bbac0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01475057919-29017-1-git-send-email-thuth@redhat.com\0" "From\0Suraj Jitindar Singh <sjitindarsingh@gmail.com>\0" "Subject\0Re: [kvm-unit-tests PATCH] powerpc: Check whether TM is available before running other tests\0" - "Date\0Thu, 29 Sep 2016 00:20:51 +0000\0" + "Date\0Thu, 29 Sep 2016 10:20:51 +1000\0" "To\0Thomas Huth <thuth@redhat.com>" " kvm@vger.kernel.org\0" "Cc\0Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" @@ -41,10 +41,10 @@ "> features\", &plen);\n" "> +\tassert(prop != NULL);\n" "> +\n" - "> +\tif (plen >= 26 && prop->data[1] = 0 && (prop->data[24] &\n" + "> +\tif (plen >= 26 && prop->data[1] == 0 && (prop->data[24] &\n" "> 0x80) != 0)\n" - "If you're checking prop->data[1] = 0 to verify device tree consistency\n" - "then maybe it's worth checking that plen = prop->data[0] as well.\n" + "If you're checking prop->data[1] == 0 to verify device tree consistency\n" + "then maybe it's worth checking that plen == prop->data[0] as well.\n" "\n" "Although in the current state these are hard coded into qemu and\n" "unlikely to ever be wrong it's probably nice to check.\n" @@ -63,7 +63,7 @@ "> +\n" "> +\tret = dt_for_each_cpu_node(cpu_has_tm, &available);\n" "> +\n" - "> +\treturn ret = 0 && available = nr_cpus;\n" + "> +\treturn ret == 0 && available == nr_cpus;\n" "> +}\n" "> \302\240\n" "> \302\240static int h_cede(void)\n" @@ -78,7 +78,7 @@ "> +\tif (!i)\n" "> +\t\treturn report_summary();\n" "> +\n" - "> \302\240\tall = argc = 1 || !strcmp(argv[1], \"all\");\n" + "> \302\240\tall = argc == 1 || !strcmp(argv[1], \"all\");\n" "> \302\240\n" "> \302\240\tfor (i = 0; hctests[i].name != NULL; i++) {\n" "Thanks for adding this check, didn't cross my mind when implementing\n" @@ -87,4 +87,4 @@ "In its current state or with changes:\n" Reviewed-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com> -6bf2af2a934367d75eebf1217770b37cdf2d3408b100dfb101aa2a2998265b41 +ed25256c468d9477bd4a0819a0993dc1a99d60c882d4a29f719f489eb60e1a8d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.