From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpdWy-0001JK-J7 for qemu-devel@nongnu.org; Thu, 29 Sep 2016 11:45:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpdWv-0006SO-S0 for qemu-devel@nongnu.org; Thu, 29 Sep 2016 11:45:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpdWv-0006SC-LC for qemu-devel@nongnu.org; Thu, 29 Sep 2016 11:45:49 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 07099D6D23 for ; Thu, 29 Sep 2016 15:45:49 +0000 (UTC) From: "Daniel P. Berrange" Date: Thu, 29 Sep 2016 16:45:32 +0100 Message-Id: <1475163940-26094-2-git-send-email-berrange@redhat.com> In-Reply-To: <1475163940-26094-1-git-send-email-berrange@redhat.com> References: <1475163940-26094-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PATCH 1/9] ui: remove misleading comment from vnc_init_state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , "Daniel P. Berrange" The last line in vnc_init_state() says /* vs might be free()ed here */ This was added in commit 198a0039c5fca224a77e9761e2350dd9cc102ad0 Author: Gerd Hoffmann Date: Tue Jun 16 14:19:48 2009 +0200 vnc: rework VncState release workflow. because the preceeding 'vnc_update_client()' could indeed release the VncState instance. The call to vnc_update_client() was removed not long after though in commit 1fc624122fb923c7fc4c1f426541d953e7df13c9 Author: Stefano Stabellini Date: Mon Aug 3 10:54:32 2009 +0100 single vnc server surface and so the comment has been wrong ever since Signed-off-by: Daniel P. Berrange --- ui/vnc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 76a3273..5faf79b 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3092,8 +3092,6 @@ void vnc_init_state(VncState *vs) vs->mouse_mode_notifier.notify = check_pointer_type_change; qemu_add_mouse_mode_change_notifier(&vs->mouse_mode_notifier); - - /* vs might be free()ed here */ } static gboolean vnc_listen_io(QIOChannel *ioc, -- 2.7.4