From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpdX7-0001SK-A1 for qemu-devel@nongnu.org; Thu, 29 Sep 2016 11:46:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpdX4-0006Ye-4M for qemu-devel@nongnu.org; Thu, 29 Sep 2016 11:46:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpdX3-0006YJ-VM for qemu-devel@nongnu.org; Thu, 29 Sep 2016 11:45:58 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 74CE664063 for ; Thu, 29 Sep 2016 15:45:57 +0000 (UTC) From: "Daniel P. Berrange" Date: Thu, 29 Sep 2016 16:45:37 +0100 Message-Id: <1475163940-26094-7-git-send-email-berrange@redhat.com> In-Reply-To: <1475163940-26094-1-git-send-email-berrange@redhat.com> References: <1475163940-26094-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PATCH 6/9] ui: remove bogus call to graphic_hw_update() in vnc_listen_io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , "Daniel P. Berrange" Just before accepting a new client connection the vnc_listen_io method calls graphic_hw_update(). This is bogus because there is a call to this method already in vnc_state_init() and the client doesn't need up2date graphics console before reaching that. Signed-off-by: Daniel P. Berrange --- ui/vnc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 2f3ebdc..d1f33d3 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3102,8 +3102,6 @@ static gboolean vnc_listen_io(QIOChannel *ioc, QIOChannelSocket *sioc = NULL; Error *err = NULL; - /* Catch-up */ - graphic_hw_update(vd->dcl.con); sioc = qio_channel_socket_accept(QIO_CHANNEL_SOCKET(ioc), &err); if (sioc != NULL) { qio_channel_set_delay(QIO_CHANNEL(sioc), false); -- 2.7.4