All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S49 00/15] i40e/i40evf updates
Date: Fri, 30 Sep 2016 00:02:35 -0700	[thread overview]
Message-ID: <1475218955.2320.37.camel@intel.com> (raw)
In-Reply-To: <1475169095-20873-1-git-send-email-bimmy.pujari@intel.com>

On Thu, 2016-09-29 at 10:11 -0700, Bimmy Pujari wrote:
> Alan Brady adds code to fix mac filters when removing vlans.
> 
> Jacob Keller drops is_vf and is_netdev fields in struct?
> i40e_mac_filter, adds code to make use of __dev_uc_sync?
> and __dev_mc_sync, moves i40e_put_mac_in_vlan and?
> i40e_del_mac_all_vlan, fixes i40e_put_mac_in_vlan to?
> return actual filter added, adds code to ignore removed?
> filters When searching all MAC/VLAN filters, implements?
> __i40e_del_filter and use where applicable, adds code to?
> store MAC/VLAN filters in a hash with the MAC Address as?
> key, adds code to properly cleanup on allocation failure?
> in i40e_sync_vsi_filters, adds code to avoid looping to?
> check whether we're in vlan mode, removes duplicate add/
> delete adminq command code for filters, corrects check?
> for reading TSYNINDX from the receive descriptor, uses a?
> mutex instead of spinlock in PTP user entry points, replaces?
> PTP Rx timestamp hang logic and adds code to avoid an extra?
> msleep while waiting for reset.
> 
> ?drivers/net/ethernet/intel/i40e/i40e.h?????????????|??50 +-
> ?drivers/net/ethernet/intel/i40e/i40e_debugfs.c?????|??92 +-
> ?drivers/net/ethernet/intel/i40e/i40e_main.c????????| 949 +++++++++++--
> --------
> ?drivers/net/ethernet/intel/i40e/i40e_ptp.c?????????| 137 +--
> ?drivers/net/ethernet/intel/i40e/i40e_txrx.c????????|???9 +-
> ?drivers/net/ethernet/intel/i40e/i40e_txrx.h????????|???2 -
> ?drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c |??57 +-
> ?drivers/net/ethernet/intel/i40evf/i40evf_main.c????|???8 +-
> ?8 files changed, 663 insertions(+), 641 deletions(-)
> 

I tried to compile the very first patch it does not compile. ?I get the
following errors:

[23:59:15 @jtkirshe-linux:next-queue]$ make -j 77 -s
? DESCEND??objtool
drivers/net/ethernet/intel/i40e/i40e_fcoe.c: In function
?i40e_fcoe_config_netdev?:
drivers/net/ethernet/intel/i40e/i40e_fcoe.c:1526:2: error: too many
arguments to function ?i40e_add_filter?
? i40e_add_filter(vsi, hw->mac.san_addr, 0, false, false);
? ^~~~~~~~~~~~~~~
In file included from drivers/net/ethernet/intel/i40e/i40e_fcoe.c:37:0:
drivers/net/ethernet/intel/i40e/i40e.h:722:25: note: declared here
?struct i40e_mac_filter *i40e_add_filter(struct i40e_vsi *vsi,
?????????????????????????^~~~~~~~~~~~~~~
drivers/net/ethernet/intel/i40e/i40e_fcoe.c:1527:2: error: too many
arguments to function ?i40e_add_filter?
? i40e_add_filter(vsi, (u8[6]) FC_FCOE_FLOGI_MAC, 0, false, false);
? ^~~~~~~~~~~~~~~
In file included from drivers/net/ethernet/intel/i40e/i40e_fcoe.c:37:0:
drivers/net/ethernet/intel/i40e/i40e.h:722:25: note: declared here
?struct i40e_mac_filter *i40e_add_filter(struct i40e_vsi *vsi,
?????????????????????????^~~~~~~~~~~~~~~
drivers/net/ethernet/intel/i40e/i40e_fcoe.c:1528:2: error: too many
arguments to function ?i40e_add_filter?
? i40e_add_filter(vsi, FIP_ALL_FCOE_MACS, 0, false, false);
? ^~~~~~~~~~~~~~~
In file included from drivers/net/ethernet/intel/i40e/i40e_fcoe.c:37:0:
drivers/net/ethernet/intel/i40e/i40e.h:722:25: note: declared here
?struct i40e_mac_filter *i40e_add_filter(struct i40e_vsi *vsi,
?????????????????????????^~~~~~~~~~~~~~~
drivers/net/ethernet/intel/i40e/i40e_fcoe.c:1529:2: error: too many
arguments to function ?i40e_add_filter?
? i40e_add_filter(vsi, FIP_ALL_ENODE_MACS, 0, false, false);
? ^~~~~~~~~~~~~~~
In file included from drivers/net/ethernet/intel/i40e/i40e_fcoe.c:37:0:
drivers/net/ethernet/intel/i40e/i40e.h:722:25: note: declared here
?struct i40e_mac_filter *i40e_add_filter(struct i40e_vsi *vsi,
?????????????????????????^~~~~~~~~~~~~~~
scripts/Makefile.build:289: recipe for target
'drivers/net/ethernet/intel/i40e/i40e_fcoe.o' failed
make[5]: *** [drivers/net/ethernet/intel/i40e/i40e_fcoe.o] Error 1
make[5]: *** Waiting for unfinished jobs....
scripts/Makefile.build:440: recipe for target
'drivers/net/ethernet/intel/i40e' failed
make[4]: *** [drivers/net/ethernet/intel/i40e] Error 2
scripts/Makefile.build:440: recipe for target 'drivers/net/ethernet/intel'
failed
make[3]: *** [drivers/net/ethernet/intel] Error 2
scripts/Makefile.build:440: recipe for target 'drivers/net/ethernet' failed
make[2]: *** [drivers/net/ethernet] Error 2
scripts/Makefile.build:440: recipe for target 'drivers/net' failed
make[1]: *** [drivers/net] Error 2
Makefile:968: recipe for target 'drivers' failed
make: *** [drivers] Error 2

So I am dropping this series. ?Make sure every patch compiles on its own,
once you fix the first patch (and any other patches that may need changes),
please resubmit the series.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160930/b46f98c1/attachment.asc>

      parent reply	other threads:[~2016-09-30  7:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-29 17:11 [Intel-wired-lan] [next PATCH S49 00/15] i40e/i40evf updates Bimmy Pujari
2016-09-29 17:11 ` [Intel-wired-lan] [next PATCH S49 01/15] i40e: drop is_vf and is_netdev fields in struct i40e_mac_filter Bimmy Pujari
2016-09-30  7:03   ` Jeff Kirsher
2016-09-29 17:11 ` [Intel-wired-lan] [next PATCH S49 02/15] i40e: make use of __dev_uc_sync and __dev_mc_sync Bimmy Pujari
2016-09-29 17:11 ` [Intel-wired-lan] [next PATCH S49 03/15] i40e: move i40e_put_mac_in_vlan and i40e_del_mac_all_vlan Bimmy Pujari
2016-09-29 17:11 ` [Intel-wired-lan] [next PATCH S49 04/15] i40e: fix i40e_put_mac_in_vlan to return actual filter added Bimmy Pujari
2016-09-29 17:11 ` [Intel-wired-lan] [next PATCH S49 05/15] i40e: When searching all MAC/VLAN filters, ignore removed filters Bimmy Pujari
2016-09-29 17:11 ` [Intel-wired-lan] [next PATCH S49 06/15] i40e: implement __i40e_del_filter and use where applicable Bimmy Pujari
2016-09-29 17:11 ` [Intel-wired-lan] [next PATCH S49 07/15] i40e: store MAC/VLAN filters in a hash with the MAC Address as key Bimmy Pujari
2016-09-29 17:11 ` [Intel-wired-lan] [next PATCH S49 08/15] i40e: properly cleanup on allocation failure in i40e_sync_vsi_filters Bimmy Pujari
2016-09-29 17:11 ` [Intel-wired-lan] [next PATCH S49 09/15] i40e: fix mac filters when removing vlans Bimmy Pujari
2016-09-29 17:11 ` [Intel-wired-lan] [next PATCH S49 10/15] i40e: avoid looping to check whether we're in vlan mode Bimmy Pujari
2016-09-29 17:11 ` [Intel-wired-lan] [next PATCH S49 11/15] i40e: remove duplicate add/delete adminq command code for filters Bimmy Pujari
2016-09-29 17:11 ` [Intel-wired-lan] [next PATCH S49 12/15] i40e: correct check for reading TSYNINDX from the receive descriptor Bimmy Pujari
2016-09-29 17:11 ` [Intel-wired-lan] [next PATCH S49 13/15] i40e: use a mutex instead of spinlock in PTP user entry points Bimmy Pujari
2016-09-29 17:11 ` [Intel-wired-lan] [next PATCH S49 14/15] i40e: replace PTP Rx timestamp hang logic Bimmy Pujari
2016-09-29 17:11 ` [Intel-wired-lan] [next PATCH S49 15/15] i40evf: avoid an extra msleep while waiting for reset Bimmy Pujari
2016-09-30  7:02 ` Jeff Kirsher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475218955.2320.37.camel@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.