From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933404AbcI3TmI (ORCPT ); Fri, 30 Sep 2016 15:42:08 -0400 Received: from smtprelay0099.hostedemail.com ([216.40.44.99]:56846 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751083AbcI3Tl6 (ORCPT ); Fri, 30 Sep 2016 15:41:58 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3867:4321:4412:4605:5007:6120:6642:10004:10400:10848:11026:11232:11473:11658:11914:12438:12740:12760:13069:13311:13357:13439:13848:14181:14659:14721:21080:21451:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: quilt25_4a86f16241d13 X-Filterd-Recvd-Size: 2615 Message-ID: <1475264510.1880.2.camel@perches.com> Subject: Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) From: Joe Perches To: Guenter Roeck , Jun Li Cc: Guenter Roeck , Felipe Balbi , Chandra Sekhar Anagani , Bruce Ashfield , Bin Gao , Pranav Tipnis , Heikki Krogerus , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Date: Fri, 30 Sep 2016 12:41:50 -0700 In-Reply-To: References: <1471986651-51139-1-git-send-email-groeck@chromium.org> <1471986651-51139-2-git-send-email-groeck@chromium.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-09-30 at 12:06 -0700, Guenter Roeck wrote: > On Thu, Sep 29, 2016 at 11:37 PM, Jun Li wrote: [] > > diff --git a/include/linux/usb/pd.h b/include/linux/usb/pd.h [] > > +#define PDO_VAR(min_mv, max_mv, max_ma) \ > > + ((PDO_TYPE_VAR << PDO_TYPE_SHIFT) | \ > > + ((((min_mv) / 50) & PDO_VAR_MIN_VOLT_MASK) << \ > > + PDO_VAR_MIN_VOLT_SHIFT) | \ > > + ((((max_mv) / 50) & PDO_VAR_MAX_VOLT_MASK) << \ > > + PDO_VAR_MAX_VOLT_SHIFT) | \ > > + ((((max_ma) / 50) & PDO_VAR_MAX_CURR_MASK) << \ > > > ((((max_ma) / 10) & PDO_VAR_MAX_CURR_MASK) << \ This would be easier to read if laid out differently. #define PDO_VAR(min_mv, max_mv, max_ma) \ ((PDO_TYPE_VAR << PDO_TYPE_SHIFT) | \ ((((min_mv) / 50) & PDO_VAR_MIN_VOLT_MASK) << PDO_VAR_MIN_VOLT_SHIFT) | \ ((((max_mv) / 50) & PDO_VAR_MAX_VOLT_MASK) << PDO_VAR_MAX_VOLT_SHIFT) | \ ((((max_ma) / 10) & PDO_VAR_MAX_CURR_MASK) << PDO_VAR_MAX_CURR_SHIFT))