From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933188AbcI3VDH (ORCPT <rfc822;w@1wt.eu>);
        Fri, 30 Sep 2016 17:03:07 -0400
Received: from smtprelay0005.hostedemail.com ([216.40.44.5]:35329 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1752047AbcI3VC6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 30 Sep 2016 17:02:58 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1714:1730:1747:1777:1792:1801:2376:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3867:3872:4321:4412:4605:5007:6120:10004:10400:10848:11026:11232:11473:11658:11914:12438:12740:13069:13311:13357:13439:13848:13894:14659:21080:21324:21451:30012:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: veil25_356a1e96e6554
X-Filterd-Recvd-Size: 2348
Message-ID: <1475269365.1880.6.camel@perches.com>
Subject: Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)
From: Joe Perches <joe@perches.com>
To: Guenter Roeck <groeck@google.com>
Cc: Jun Li <jun.li@nxp.com>, Guenter Roeck <groeck@chromium.org>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        Chandra Sekhar Anagani <chandra.sekhar.anagani@intel.com>,
        Bruce Ashfield <bruce.ashfield@windriver.com>,
        Bin Gao <bin.gao@intel.com>, Pranav Tipnis <pranav.tipnis@intel.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Date: Fri, 30 Sep 2016 14:02:45 -0700
In-Reply-To: <CABXOdTc6fA0RM-Osw96Dwwcy0PG1tyq-E07Fs2TJceYOe1ng6A@mail.gmail.com>
References: <1471986651-51139-1-git-send-email-groeck@chromium.org>
         <1471986651-51139-2-git-send-email-groeck@chromium.org>
         <VI1PR0401MB25606B7501E38D64C37E33CE89C10@VI1PR0401MB2560.eurprd04.prod.outlook.com>
         <CABXOdTfMRFLohkH7aVOXwEi3cGh=nOPYToEVEY-9xJ8yYH9BBQ@mail.gmail.com>
         <1475264510.1880.2.camel@perches.com>
         <CABXOdTc6fA0RM-Osw96Dwwcy0PG1tyq-E07Fs2TJceYOe1ng6A@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.21.91-1ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2016-09-30 at 13:57 -0700, Guenter Roeck wrote:
> Code now looks as follows.
> 
> #define PDO_VAR_MIN_VOLT(mv) ((((mv) / 50) & PDO_VAR_MIN_VOLT_MASK) << \
>                               PDO_VAR_MIN_VOLT_SHIFT)
> #define PDO_VAR_MAX_VOLT(mv) ((((mv) / 50) & PDO_VAR_MAX_VOLT_MASK) << \
>                               PDO_VAR_MAX_VOLT_SHIFT)
> #define PDO_VAR_MAX_CURR(ma) ((((ma) / 10) & PDO_VAR_MAX_CURR_MASK) << \
>                               PDO_VAR_MAX_CURR_SHIFT)

When #defines are continued, I generally find it nicer to have the
entire definition on a separate line

#define PDO_VAR_MIN_VOLT(mv)						\
	((((mv) / 50) & PDO_VAR_MIN_VOLT_MASK) << PDO_VAR_MIN_VOLT_SHIFT)

> Though maybe I should just ignore line length limits or use shorter defines.

When it makes sense, yes please.