From: Ico Doornekamp <ico@pruts.nl>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] io: adc: ad7606_core: fix signed/unsigned number comparison
Date: Sat, 01 Oct 2016 18:17:02 +0200 [thread overview]
Message-ID: <1475338371-sup-5926@pruts.nl> (raw)
In-Reply-To: <c4a0a801-14d6-7ea9-ec4f-958449a9dcb6@kernel.org>
* On 2016-10-01 18:09:44 +0200, Jonathan Cameron wrote:
> On 28/09/16 14:41, Ico Doornekamp wrote:
> > reported by 'make W=2' in ad7606_oversampling_get_index()
> >
> > Signed-off-by: Ico Doornekamp <ico@pruts.nl>
> hmm. It's pretty much a non problem in the first place as we know
> it can't cause issues (can see it is 7). Also this really just
> moves to typecasting it later when we return i.
>
> So unless I'm missing something I'm not going to apply this one.
Fair enough. It's one of those little penguin task things again, you
probably guessed already. 'Find a bug reported by sparse and fix it'.
But your IIO tree is simply too high-quality, sparse has nothing to
complain :)
--
:wq
^X^Cy^K^X^C^C^C^C
next prev parent reply other threads:[~2016-10-01 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 13:41 [PATCH] io: adc: ad7606_core: fix signed/unsigned number comparison Ico Doornekamp
2016-10-01 16:09 ` Jonathan Cameron
2016-10-01 16:17 ` Ico Doornekamp [this message]
2016-10-01 16:49 ` Alison Schofield
2016-10-01 17:27 ` Ico Doornekamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475338371-sup-5926@pruts.nl \
--to=ico@pruts.nl \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.