From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Unalias obj->phys_handle and obj->userptr
Date: Mon, 03 Oct 2016 10:18:03 +0300 [thread overview]
Message-ID: <1475479083.3067.3.camel@linux.intel.com> (raw)
In-Reply-To: <20160930173139.24397-1-chris@chris-wilson.co.uk>
On pe, 2016-09-30 at 18:31 +0100, Chris Wilson wrote:
> We use obj->phys_handle to choose the pread/pwrite path, but as
> obj->phys_handle is a union with obj->userptr, we then mistakenly use
> the phys_handle path for userptr objects within pread/pwrite.
>
> Testcase: igt/gem_userptr_blits/forbidden-operations
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97519
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: stable@vger.kernel.org
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Unalias obj->phys_handle and obj->userptr
Date: Mon, 03 Oct 2016 10:18:03 +0300 [thread overview]
Message-ID: <1475479083.3067.3.camel@linux.intel.com> (raw)
In-Reply-To: <20160930173139.24397-1-chris@chris-wilson.co.uk>
On pe, 2016-09-30 at 18:31 +0100, Chris Wilson wrote:
> We use obj->phys_handle to choose the pread/pwrite path, but as
> obj->phys_handle is a union with obj->userptr, we then mistakenly use
> the phys_handle path for userptr objects within pread/pwrite.
>
> Testcase: igt/gem_userptr_blits/forbidden-operations
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97519
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: stable@vger.kernel.org
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
next prev parent reply other threads:[~2016-10-03 7:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 17:31 [PATCH] drm/i915: Unalias obj->phys_handle and obj->userptr Chris Wilson
2016-09-30 17:31 ` Chris Wilson
2016-09-30 18:19 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-10-03 7:18 ` Joonas Lahtinen [this message]
2016-10-03 7:18 ` [Intel-gfx] [PATCH] " Joonas Lahtinen
2016-10-13 13:11 ` Daniel Vetter
2016-10-13 13:11 ` [Intel-gfx] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475479083.3067.3.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.