From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH] drm/i915: Unalias obj->phys_handle and obj->userptr Date: Mon, 03 Oct 2016 10:18:03 +0300 Message-ID: <1475479083.3067.3.camel@linux.intel.com> References: <20160930173139.24397-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id E62F16E4BE for ; Mon, 3 Oct 2016 07:18:06 +0000 (UTC) In-Reply-To: <20160930173139.24397-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org T24gcGUsIDIwMTYtMDktMzAgYXQgMTg6MzEgKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBX ZSB1c2Ugb2JqLT5waHlzX2hhbmRsZSB0byBjaG9vc2UgdGhlIHByZWFkL3B3cml0ZSBwYXRoLCBi dXQgYXMKPiBvYmotPnBoeXNfaGFuZGxlIGlzIGEgdW5pb24gd2l0aCBvYmotPnVzZXJwdHIsIHdl IHRoZW4gbWlzdGFrZW5seSB1c2UKPiB0aGUgcGh5c19oYW5kbGUgcGF0aCBmb3IgdXNlcnB0ciBv YmplY3RzIHdpdGhpbiBwcmVhZC9wd3JpdGUuCj4gCj4gVGVzdGNhc2U6IGlndC9nZW1fdXNlcnB0 cl9ibGl0cy9mb3JiaWRkZW4tb3BlcmF0aW9ucwo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJl ZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD05NzUxOQo+IFNpZ25lZC1vZmYtYnk6IENocmlz IFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBzdGFibGVAdmdlci5rZXJu ZWwub3JnCgpSZXZpZXdlZC1ieTogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGlu dXguaW50ZWwuY29tPgoKUmVnYXJkcywgSm9vbmFzCi0tIApKb29uYXMgTGFodGluZW4KT3BlbiBT b3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKSW50ZWwgQ29ycG9yYXRpb24KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:2488 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbcJCHSH (ORCPT ); Mon, 3 Oct 2016 03:18:07 -0400 Message-ID: <1475479083.3067.3.camel@linux.intel.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Unalias obj->phys_handle and obj->userptr From: Joonas Lahtinen To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: stable@vger.kernel.org Date: Mon, 03 Oct 2016 10:18:03 +0300 In-Reply-To: <20160930173139.24397-1-chris@chris-wilson.co.uk> References: <20160930173139.24397-1-chris@chris-wilson.co.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On pe, 2016-09-30 at 18:31 +0100, Chris Wilson wrote: > We use obj->phys_handle to choose the pread/pwrite path, but as > obj->phys_handle is a union with obj->userptr, we then mistakenly use > the phys_handle path for userptr objects within pread/pwrite. > > Testcase: igt/gem_userptr_blits/forbidden-operations > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97519 > Signed-off-by: Chris Wilson > Cc: stable@vger.kernel.org Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation