From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [Intel-gfx] [PATCH] drm/prime: Passing the right owner through to dma_buf_export() Date: Mon, 03 Oct 2016 10:26:00 +0300 Message-ID: <1475479560.3067.7.camel@linux.intel.com> References: <20160930103805.13550-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160930103805.13550-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson , dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gcGUsIDIwMTYtMDktMzAgYXQgMTE6MzggKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBk bWFfYnVmX2V4cG9ydCgpIGFkZHMgYSByZWZlcmVuY2UgdG8gdGhlIG93bmluZyBtb2R1bGUgdG8g dGhlIGRtYWJ1ZiAodG8KPiBwcmV2ZW50IHRoZSBkcml2ZXIgZnJvbSBiZWluZyB1bmxvYWRlZCB3 aGlsc3QgYSB0aGlyZCBwYXJ0eSBzdGlsbCByZWZlcnMKPiB0byB0aGUgZG1hYnVmKS4gSG93ZXZl ciwgZHJtX2dlbV9wcmltZV9leHBvcnQoKSB3YXMgcGFzc2luZyBpdHMgb3duCj4gVEhJU19NT0RV TEUgKGkuZS4gZHJtLmtvKSByYXRoZXIgdGhhbiB0aGUgZHJpdmVyLiBFeHBhbmQgdGhlIGludGVy ZmFjZQo+IHNvIHRoYXQgZHJpdmVyIHBhc3NlcyB0aGUgc3RydWN0IG1vZHVsZSB0byB0aGUgaGVs cGVyLgo+IAo+IFRlc3RjYXNlOiBpZ3QvdmdlbV9yZWxvYWRfYmFzaWMKPiBSZXBvcnRlZC1ieTog UGV0cmkgTGF0dmFsYSA8cGV0cmkubGF0dmFsYUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTog Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IFBldHJpIExhdHZh bGEgPHBldHJpLmxhdHZhbGFAaW50ZWwuY29tPgo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3Jn CgpGcm9tIHByZXZpb3VzIGV4cGVyaWVuY2UgKHdpdGggdGhlIEJJVCgpIGNvbnZlcnNpb24pLCBl eHBlY3RhdGlvbiBpcyB0bwpDQyBhbGwgZHJpdmVyIG1haW50YWluZXJzLCBldmVuIGZvciBzaW1w bGUgY2hhbmdlcy4gU2hvdWxkIG5vdCBiZSBoYXJkCnRvIHNwbGl0IHRoaXMgY2hhbmdlIGVpdGhl ci4KCkNvZGUgaXMgYW55d2F5OwoKUmV2aWV3ZWQtYnk6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFz LmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KClJlZ2FyZHMsIEpvb25hcwotLSAKSm9vbmFzIExh aHRpbmVuCk9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCkludGVsIENvcnBvcmF0aW9uCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:1206 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752479AbcJCH0M (ORCPT ); Mon, 3 Oct 2016 03:26:12 -0400 Message-ID: <1475479560.3067.7.camel@linux.intel.com> Subject: Re: [Intel-gfx] [PATCH] drm/prime: Passing the right owner through to dma_buf_export() From: Joonas Lahtinen To: Chris Wilson , dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Date: Mon, 03 Oct 2016 10:26:00 +0300 In-Reply-To: <20160930103805.13550-1-chris@chris-wilson.co.uk> References: <20160930103805.13550-1-chris@chris-wilson.co.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On pe, 2016-09-30 at 11:38 +0100, Chris Wilson wrote: > dma_buf_export() adds a reference to the owning module to the dmabuf (to > prevent the driver from being unloaded whilst a third party still refers > to the dmabuf). However, drm_gem_prime_export() was passing its own > THIS_MODULE (i.e. drm.ko) rather than the driver. Expand the interface > so that driver passes the struct module to the helper. > > Testcase: igt/vgem_reload_basic > Reported-by: Petri Latvala > Signed-off-by: Chris Wilson > Cc: Petri Latvala > Cc: stable@vger.kernel.org >>From previous experience (with the BIT() conversion), expectation is to CC all driver maintainers, even for simple changes. Should not be hard to split this change either. Code is anyway; Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation