From: Scott Wood <oss@buserror.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] Rearrange CONFIG_* macros
Date: Mon, 03 Oct 2016 11:35:45 -0500 [thread overview]
Message-ID: <1475512545.4917.5.camel@buserror.net> (raw)
In-Reply-To: <20161001022426.GJ4884@bill-the-cat>
On Fri, 2016-09-30 at 22:24 -0400, Tom Rini wrote:
> On Fri, Sep 30, 2016 at 04:20:10AM +0000, york sun wrote:
> >
> > On 09/29/2016 08:59 PM, Masahiro Yamada wrote:
> > >
> > > ? If X86 and FSL are the only platforms that have interest in this
> > > option,
> > > ? we can save HAVE_... and put them directly in "depends on".
> > >
> > > ????config MAX_CPUS
> > > ?????????int "Maximum number of CPUs permitted"
> > > ?????????depends on (SMP && X86) || VENDOR_FSL
> > >
> > > ? I am not quite sure about "VENDOR_FSL",
> > > ???so please choose your favorite one like
> > > ? SOC_FSL, PLAT_FSL, ARCH_FSL, or whatever.
> > This sounds like a bandage. I can go with this if there is no better?
> > solution.
> If MAX_CPUS has the same meaning in both cases, this isn't imho a
> bandage but one of the cleanups that was hoped for in moving to Kconfig.
> We see that a problem is encountered in more than one area more easily
> and instead of letting N solutions accumulate we get one.
It's the depends line that looks like a bandage -- can't it just be "depends
on SMP", and if there are any SMP platforms that can't be immediately
converted to use this (e.g. the non-CONFIG MAX_CPUS define in
arch/arm/cpu/armv7/mx6/mp.c should be pretty easily convertible), add a TODO
note in the help text indicating that?
-Scott
prev parent reply other threads:[~2016-10-03 16:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 17:39 [U-Boot] [RFC] Rearrange CONFIG_* macros york sun
2016-09-27 17:51 ` Tom Rini
2016-09-27 18:24 ` york sun
2016-09-27 18:40 ` Tom Rini
2016-09-27 17:55 ` Simon Glass
2016-09-27 18:26 ` york sun
2016-09-28 18:57 ` york sun
2016-09-28 19:17 ` Simon Glass
2016-09-29 15:47 ` york sun
2016-09-30 3:59 ` Masahiro Yamada
2016-09-30 4:20 ` york sun
2016-10-01 2:24 ` Tom Rini
2016-10-03 16:35 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475512545.4917.5.camel@buserror.net \
--to=oss@buserror.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.