From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752423AbcJCXZw (ORCPT ); Mon, 3 Oct 2016 19:25:52 -0400 Received: from smtprelay0015.hostedemail.com ([216.40.44.15]:45482 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751521AbcJCXZw (ORCPT ); Mon, 3 Oct 2016 19:25:52 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3866:3867:4321:5007:6642:10004:10400:10848:11232:11658:11914:12043:12296:12740:12760:13069:13311:13357:13439:14659:14721:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: event05_15cd7c6851049 X-Filterd-Recvd-Size: 1763 Message-ID: <1475537148.1923.1.camel@perches.com> Subject: Re: [PATCH 4/8] staging: rts5208: Logical continuation fixes From: Joe Perches To: Wayne Porter , gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 03 Oct 2016 16:25:48 -0700 In-Reply-To: <1c357be0ddc863d4aa1dcc07d45e3da427f10907.1475535232.git.wporter82@gmail.com> References: <1c357be0ddc863d4aa1dcc07d45e3da427f10907.1475535232.git.wporter82@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.0-2ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-10-03 at 23:17 +0000, Wayne Porter wrote: > Checkpatch detected multiple instances of logical continuation warnings [] > diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c [] > @@ -819,11 +819,11 @@ static int reset_xd(struct rtsx_chip *chip) > } > > if ((buf[0] == 0x01) && (buf[1] == 0x03) && > - (buf[2] == 0xD9) > - && (buf[3] == 0x01) && (buf[4] == 0xFF) > - && (buf[5] == 0x18) && (buf[6] == 0x02) > - && (buf[7] == 0xDF) && (buf[8] == 0x01) > - && (buf[9] == 0x20)) { > + (buf[2] == 0xD9) && > + (buf[3] == 0x01) && (buf[4] == 0xFF) && > + (buf[5] == 0x18) && (buf[6] == 0x02) && > + (buf[7] == 0xDF) && (buf[8] == 0x01) && > + (buf[9] == 0x20)) { memcmp might be easier to read if (!memcmp(buf, "\x01\x03\xd9\x01\xff\x18\x02\xdf\x01\x20", 10))