From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH RESEND 1/2] drm/i915: workaround sparse warning on variable length arrays
Date: Tue, 04 Oct 2016 12:58:26 +0300 [thread overview]
Message-ID: <1475575106.6286.2.camel@linux.intel.com> (raw)
In-Reply-To: <1475574853-4178-1-git-send-email-jani.nikula@intel.com>
On ti, 2016-10-04 at 12:54 +0300, Jani Nikula wrote:
> @@ -192,7 +192,7 @@ static void broadwell_sseu_info_init(struct drm_i915_private *dev_priv)
> struct sseu_dev_info *sseu = &mkwrite_device_info(dev_priv)->sseu;
> const int s_max = 3, ss_max = 3, eu_max = 8;
Does sparse shut up if you split these into their own lines?
> int s, ss;
> - u32 fuse2, eu_disable[s_max];
> + u32 fuse2, eu_disable[3]; /* s_max */
If not;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-04 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 9:54 [PATCH RESEND 1/2] drm/i915: workaround sparse warning on variable length arrays Jani Nikula
2016-10-04 9:54 ` [PATCH RESEND 2/2] drm/i915: silence io mapping/unmapping sparse warnings on different address spaces Jani Nikula
2016-10-04 10:13 ` Joonas Lahtinen
2016-10-04 9:58 ` Joonas Lahtinen [this message]
2016-10-04 10:09 ` [PATCH RESEND 1/2] drm/i915: workaround sparse warning on variable length arrays Jani Nikula
2016-10-04 11:49 ` ✗ Fi.CI.BAT: warning for series starting with [RESEND,1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475575106.6286.2.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.